Install eslint-plugin-package-json with recommended config#617
Merged
FloEdelmann merged 6 commits intomainfrom Mar 9, 2026
Merged
Install eslint-plugin-package-json with recommended config#617FloEdelmann merged 6 commits intomainfrom
eslint-plugin-package-json with recommended config#617FloEdelmann merged 6 commits intomainfrom
Conversation
Co-authored-by: FloEdelmann <[email protected]>
Copilot
AI
changed the title
[WIP] Install eslint-plugin-package-json and fix lint issues
Install eslint-plugin-package-json with recommended config
Mar 9, 2026
FloEdelmann
reviewed
Mar 9, 2026
Co-authored-by: FloEdelmann <[email protected]>
FloEdelmann
reviewed
Mar 9, 2026
…ue.css Co-authored-by: FloEdelmann <[email protected]>
eslint-plugin-package-json with recommended config
There was a problem hiding this comment.
Pull request overview
This PR introduces eslint-plugin-package-json and updates package.json metadata to satisfy the plugin’s recommended rules, while ensuring key published artifacts remain consumable.
Changes:
- Add
eslint-plugin-package-jsonand enable its recommended flat config ineslint.config.js. - Add
exports,files, andsideEffectsfields topackage.json(and sort scripts lexicographically). - Remove
.npmignorein favor of the newfilesallowlist.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Adds exports map, publish files allowlist, sideEffects: false, and reorders scripts; adds new eslint plugin dev dependency. |
| package-lock.json | Locks new eslint-plugin-package-json dependency tree (including peer jsonc-eslint-parser). |
| eslint.config.js | Enables eslint-plugin-package-json recommended config in flat ESLint config. |
| .npmignore | Removed; publishing behavior is now controlled via files in package.json. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
eslint-plugin-package-jsonas a dev dependencyeslintPluginPackageJson.configs.recommendedtoeslint.config.jspackage-json/require-exports— addexportsfield topackage.jsonpackage-json/require-files— addfilesfield topackage.jsonpackage-json/require-sideEffects— addsideEffects: falsetopackage.jsonpackage-json/sort-collections— sortscriptslexicographicallyexportsmap soembetty-vue/dist/embetty-vue.cssandembetty-vue/dist/embetty-vue.min.cssremain importable.vuefile changes.npmignore(superseded byfilesfield)💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.