Skip to content

Install eslint-plugin-package-json with recommended config#617

Merged
FloEdelmann merged 6 commits intomainfrom
copilot/install-eslint-plugin-package-json
Mar 9, 2026
Merged

Install eslint-plugin-package-json with recommended config#617
FloEdelmann merged 6 commits intomainfrom
copilot/install-eslint-plugin-package-json

Conversation

Copy link
Contributor

Copilot AI commented Mar 9, 2026

  • Install eslint-plugin-package-json as a dev dependency
  • Add eslintPluginPackageJson.configs.recommended to eslint.config.js
  • Fix package-json/require-exports — add exports field to package.json
  • Fix package-json/require-files — add files field to package.json
  • Fix package-json/require-sideEffects — add sideEffects: false to package.json
  • Fix package-json/sort-collections — sort scripts lexicographically
  • Add CSS entries to exports map so embetty-vue/dist/embetty-vue.css and embetty-vue/dist/embetty-vue.min.css remain importable
  • Revert unrelated .vue file changes
  • Remove .npmignore (superseded by files field)

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI changed the title [WIP] Install eslint-plugin-package-json and fix lint issues Install eslint-plugin-package-json with recommended config Mar 9, 2026
@FloEdelmann FloEdelmann requested a review from Copilot March 9, 2026 14:09
@FloEdelmann FloEdelmann marked this pull request as ready for review March 9, 2026 14:09
@FloEdelmann FloEdelmann changed the title Install eslint-plugin-package-json with recommended config Install eslint-plugin-package-json with recommended config Mar 9, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces eslint-plugin-package-json and updates package.json metadata to satisfy the plugin’s recommended rules, while ensuring key published artifacts remain consumable.

Changes:

  • Add eslint-plugin-package-json and enable its recommended flat config in eslint.config.js.
  • Add exports, files, and sideEffects fields to package.json (and sort scripts lexicographically).
  • Remove .npmignore in favor of the new files allowlist.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
package.json Adds exports map, publish files allowlist, sideEffects: false, and reorders scripts; adds new eslint plugin dev dependency.
package-lock.json Locks new eslint-plugin-package-json dependency tree (including peer jsonc-eslint-parser).
eslint.config.js Enables eslint-plugin-package-json recommended config in flat ESLint config.
.npmignore Removed; publishing behavior is now controlled via files in package.json.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@FloEdelmann FloEdelmann added the npm-patch When a PR with this label is merged into master, a new patch version (x.x.X) is released on npm. label Mar 9, 2026
@FloEdelmann FloEdelmann merged commit 4687a54 into main Mar 9, 2026
@FloEdelmann FloEdelmann deleted the copilot/install-eslint-plugin-package-json branch March 9, 2026 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

npm-patch When a PR with this label is merged into master, a new patch version (x.x.X) is released on npm.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants