feat: Expose extraTemplateSpec, fix api extraSpec location#547
Merged
germangarces merged 3 commits intoJun 16, 2026
Conversation
added 2 commits
June 12, 2026 10:29
task-processor for customizing spec.template.spec
There was a problem hiding this comment.
Code Review
This pull request adds the extraTemplateSpec field to several deployment templates (api, frontend, pgbouncer, sse, and task-processor) to allow custom configuration of spec.template.spec. The reviewer identified a critical issue across all these templates: if extraVolumes is empty but extraTemplateSpec is provided, the templates will render an empty volumes: key, causing Kubernetes API validation to fail. The reviewer suggests conditionally rendering the volumes: block only when volumes are actually defined.
germangarces
approved these changes
Jun 16, 2026
germangarces
left a comment
Member
There was a problem hiding this comment.
Thanks for the contrib @DelineaMosher
👍 LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
Changes
Add
extraTemplateSpecto be added tospec.template.specin 5 templates. Allows specifying additional fields likepriorityClassName. Addresses #446In
values.yamlmoveextraSpecoutside ofbootstrapand directly underapi. Template reads from.Values.api.extraSpec, not.Values.api.bootsrap.extraSpec.How did you test this code?
api.extraSpecfix6 Verify
volumes:included only ifextraVolumesis specified.