Skip to content

docs: add npm build to readme.md#108

Open
kokehiM0chi wants to merge 1 commit intoFinschia:mainfrom
kokehiM0chi:add-description-readme
Open

docs: add npm build to readme.md#108
kokehiM0chi wants to merge 1 commit intoFinschia:mainfrom
kokehiM0chi:add-description-readme

Conversation

@kokehiM0chi
Copy link

@kokehiM0chi kokehiM0chi commented Jan 12, 2024

To run scripts/finschia/init.sh, module @finschia/finschia is required. So, it is necesary to run npm build.

Checklist:

  • I have added a relevant changelog to CHANGELOG.md. (not needed)
  • I have added tests to cover my changes. (not needed)
  • I have updated the documentation accordingly. (not needed)

To run scripts/finschia/init.sh, module `@finschia/finschia` is required.
So, it is necesary to run `npm build`.
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@kokehiM0chi kokehiM0chi requested a review from zemyblue January 12, 2024 08:50
@kokehiM0chi kokehiM0chi self-assigned this Jan 12, 2024
Run the following:

```npm
npm run build
Copy link
Contributor

@zemyblue zemyblue Jan 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change to yarn install & yarn build.
Because finschia-js use yarn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants