WstxValidationException: Unknown reason (at end element </nl:nillableIntElement>) when validating a document with nillable elements

[ppalaga]

fix #179
fix #190

[ppalaga]

@cowtowncoder here is the first sketch of what could become a real fix. Any feedback would be appreciated.

[cowtowncoder]

With a quick look that makes sense.

My one concern is that the attributes should only be tracked when information is needed (validation enabled, or duplicate check), and avoided otherwise.
This because keeping track with a Maps will add measurable overhead for common case where validation is not enabled.

[ppalaga]

Thank for the feedback, @cowtowncoder!

My one concern is that the attributes should only be tracked when information is needed (validation enabled, or duplicate check), and avoided otherwise. This because keeping track with a Maps will add measurable overhead for common case where validation is not enabled.

+1. If SimpleOutputElement is the right place to implement the attribute tracking, then I can gladly have a look to make the implementation more performant.

[ppalaga]

My one concern is that the attributes should only be tracked when information is needed (validation enabled, or duplicate check)

That's actually the case already. All calls of SimpleOutputElement.checkAttrWrite(String, String, String, String) are guarded by either BaseStreamWriter.mCheckAttrs or by BaseStreamWriter.mValidator != null.

[ppalaga]

Only the last commit is relevant. The rest is also available in #191 where we can discuss it separately.

@cowtowncoder could you please review?

[grigoni]

hi @cowtowncoder, I'm interested in this fix, can you please have a look? thanks a lot

[ppalaga]

@grigoni I apologize, this hangs due to legal issues with the Contributor Agreement on the side of my company.

[janssendj]

Is this still hanging on the CA ?

[cowtowncoder]

@janssendj No progress that I can see. Although now there are also merge conflicts to resolve.

[ppalaga]

Yeah, I'd be ready to resolve the merge conflicts once the legal issues are solved.

[igorsim-gb]

hi @cowtowncoder, I'm interested in this fix. Is there an estimate for when this PR is expected to be accepted?

[cowtowncoder]

@igorsim-gb As you can see from above, it is waiting for CLA. After which conflicts may be resolved.