Support alternate radixes for numeric values by tiger9800 · Pull Request #5445 · FasterXML/jackson-databind

tiger9800 · 2025-11-29T22:51:23Z

Add support for radices using the added to JsonFormat radix attribute in FasterXML/jackson-annotations#321. The initial work for the PR was done in issue #5317, and the original request was #221.

src/main/java/tools/jackson/databind/deser/std/StdDeserializer.java

src/main/java/tools/jackson/databind/introspect/ConcreteBeanPropertyBase.java

cowtowncoder · 2025-12-04T03:33:53Z

src/main/java/tools/jackson/databind/introspect/ConcreteBeanPropertyBase.java

+        JsonFormat.Value v2 = null;
+        AnnotationIntrospector intr = config.getAnnotationIntrospector();
+        if (intr != null) {
+            AnnotatedMember member = getMember();


Why are we mixing in member annotations now -- this changes semantics of the method.

EDIT: never mind, that was done via findFormatOverrides() which does about same. But maybe call that method instead of inlining the logic?

Done. Do not remember why I inlined in #5317

github-actions · 2025-12-12T00:22:33Z

🧪 Code Coverage Report

Metric	Coverage	Change
Instructions	78.7%	📈 +0.0%
Branches	72.5%	📈 +0.0%

github-actions · 2025-12-12T02:26:54Z

🧪 Code Coverage Report

Metric	Coverage	Change
Instructions	78.7%	📈 +0.000%
Branches	72.5%	📈 +0.000%

github-actions · 2025-12-12T04:45:24Z

🧪 Code Coverage Report

Metric	Coverage	Change
Instructions	78.7%	📈 +0.000%
Branches	72.5%	📈 +0.000%

github-actions · 2025-12-12T04:52:29Z

🧪 Code Coverage Report

Metric	Coverage	Change
Instructions	78.7%	📈 +0.000%
Branches	72.5%	📈 +0.000%

github-actions · 2025-12-21T01:48:22Z

🧪 Code Coverage Report

Metric	Coverage	Change
Instructions	78.77%	📈 +0.000%
Branches	72.57%	📈 +0.040%

src/main/java/tools/jackson/databind/cfg/ConfigOverrides.java

github-actions · 2025-12-21T01:56:05Z

🧪 Code Coverage Report

Metric	Coverage	Change
Instructions	78.77%	📈 +0.000%
Branches	72.55%	📈 +0.020%

github-actions · 2025-12-21T01:59:21Z

🧪 Code Coverage Report

Metric	Coverage	Change
Instructions	78.77%	📈 +0.000%
Branches	72.56%	📈 +0.030%

src/main/java/tools/jackson/databind/deser/std/FromStringWithRadixToNumberDeserializer.java

github-actions · 2025-12-21T02:00:00Z

🧪 Code Coverage Report

Metric	Coverage	Change
Instructions	78.78%	📈 +0.010%
Branches	72.57%	📈 +0.040%

github-actions · 2025-12-21T02:34:21Z

🧪 Code Coverage Report

Metric	Coverage	Change
Instructions	78.76%	📉 -0.010%
Branches	72.54%	📈 +0.010%

github-actions · 2025-12-21T02:35:19Z

🧪 Code Coverage Report

Metric	Coverage	Change
Instructions	78.76%	📉 -0.010%
Branches	72.54%	📈 +0.010%

github-actions · 2025-12-21T04:05:09Z

🧪 Code Coverage Report

Metric	Coverage	Change
Instructions	78.75%	📉 -0.020%
Branches	72.54%	📈 +0.020%

github-actions · 2025-12-21T04:18:04Z

🧪 Code Coverage Report

Metric	Coverage	Change
Instructions	78.76%	📉 -0.010%
Branches	72.55%	📈 +0.030%

cowtowncoder

LGTM

github-actions · 2025-12-21T04:35:11Z

🧪 Code Coverage Report

Metric	Coverage	Change
Instructions	78.77%	📈 +0.000%
Branches	72.56%	📈 +0.040%

github-actions · 2025-12-21T04:36:41Z

🧪 Code Coverage Report

Metric	Coverage	Change
Instructions	78.76%	📉 -0.010%
Branches	72.54%	📈 +0.020%

cowtowncoder · 2025-12-21T04:36:46Z

@tiger9800 Phew! I think this is about ready for me to merge. Great job, I like how things evolved.

Will let this simmer until tomorrow and then hope to merge.

github-actions · 2025-12-22T01:18:53Z

🧪 Code Coverage Report

Metric	Coverage	Change
Instructions	78.76%	📉 -0.010%
Branches	72.55%	📈 +0.030%

github-actions · 2025-12-22T01:26:06Z

🧪 Code Coverage Report

Metric	Coverage	Change
Instructions	78.77%	📈 +0.000%
Branches	72.56%	📈 +0.030%

tiger9800 and others added 5 commits November 29, 2025 16:49

Support alternate radixes for numeric values

b7b55f2

Merge branch '3.x' into 3.x-forked

c3b038e

Merge branch '3.x' into 3.x-forked

740b399

Merge branch '3.x' into 3.x-forked

209859d

Merge branch '3.x' into 3.x-forked

79098fd

cowtowncoder reviewed Dec 4, 2025

View reviewed changes

src/main/java/tools/jackson/databind/deser/std/StdDeserializer.java Outdated Show resolved Hide resolved

cowtowncoder reviewed Dec 4, 2025

View reviewed changes

src/main/java/tools/jackson/databind/introspect/ConcreteBeanPropertyBase.java Outdated Show resolved Hide resolved

cowtowncoder reviewed Dec 4, 2025

View reviewed changes

src/main/java/tools/jackson/databind/introspect/ConcreteBeanPropertyBase.java Show resolved Hide resolved

cowtowncoder reviewed Dec 4, 2025

View reviewed changes

Fix PR comments

7d3714b

tiger9800 requested a review from cowtowncoder December 11, 2025 23:48

Merge branch '3.x' into 3.x-forked

cce892a

Merge branch '3.x' into 3.x-forked

b0c62b9

Merge branch '3.x' into 3.x-forked

a1bc614

Merge branch '3.x' into 3.x-forked

cf14de6

Minor reordering, style changes

2c7d34e

cowtowncoder reviewed Dec 21, 2025

View reviewed changes

src/main/java/tools/jackson/databind/cfg/ConfigOverrides.java Show resolved Hide resolved

Minor reordering

66da4e1

cowtowncoder added 2 commits December 20, 2025 17:56

warnings removal

629fd52

...

0dbf7f7

cowtowncoder reviewed Dec 21, 2025

View reviewed changes

src/main/java/tools/jackson/databind/deser/std/FromStringWithRadixToNumberDeserializer.java Outdated Show resolved Hide resolved

Robustify deserialization

d608949

...

996e1bd

Update to apply global format defaults before per-type overrides.

100c501

Add failure tests

3387c53

Bit of refactoring to straighten out access

9c3bd86

cowtowncoder approved these changes Dec 21, 2025

View reviewed changes

Merge branch '3.x' into 3.x-forked

87eb902

cowtowncoder added the 3.1 label Dec 21, 2025

cowtowncoder added this to the 3.1.0 milestone Dec 21, 2025

Merge branch '3.x' into 3.x-forked

19e63e5

cowtowncoder added the cla-received PR already covered by CLA (optional label) label Dec 22, 2025

Release note update

b35afb2

cowtowncoder merged commit 273dad9 into FasterXML:3.x Dec 22, 2025
6 checks passed

cowtowncoder mentioned this pull request Dec 22, 2025

Support alternate radixes when writing numeric values as strings #221

Closed

Uh oh!

Comments

Conversation

tiger9800 commented Nov 29, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cowtowncoder Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tiger9800 Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Dec 12, 2025

🧪 Code Coverage Report

Uh oh!

github-actions bot commented Dec 12, 2025

🧪 Code Coverage Report

Uh oh!

github-actions bot commented Dec 12, 2025

🧪 Code Coverage Report

Uh oh!

github-actions bot commented Dec 12, 2025

🧪 Code Coverage Report

Uh oh!

github-actions bot commented Dec 21, 2025

🧪 Code Coverage Report

Uh oh!

Uh oh!

github-actions bot commented Dec 21, 2025

🧪 Code Coverage Report

Uh oh!

github-actions bot commented Dec 21, 2025

🧪 Code Coverage Report

Uh oh!

Uh oh!

github-actions bot commented Dec 21, 2025

🧪 Code Coverage Report

Uh oh!

github-actions bot commented Dec 21, 2025

🧪 Code Coverage Report

Uh oh!

github-actions bot commented Dec 21, 2025

🧪 Code Coverage Report

Uh oh!

github-actions bot commented Dec 21, 2025

🧪 Code Coverage Report

Uh oh!

github-actions bot commented Dec 21, 2025

🧪 Code Coverage Report

Uh oh!

cowtowncoder left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Dec 21, 2025

🧪 Code Coverage Report

Uh oh!

github-actions bot commented Dec 21, 2025

🧪 Code Coverage Report

Uh oh!

cowtowncoder commented Dec 21, 2025

Uh oh!

github-actions bot commented Dec 22, 2025

🧪 Code Coverage Report

Uh oh!

github-actions bot commented Dec 22, 2025

🧪 Code Coverage Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

cowtowncoder Dec 4, 2025 •

edited

Loading