Merged
Conversation
apply_fn in critic_train_state is incorrect and uses the actor apply. fixed it to use the critic one.
bsarkar321
approved these changes
Jul 2, 2025
Collaborator
bsarkar321
left a comment
bsarkar321
left a comment
There was a problem hiding this comment.
Thanks! It seems like apply_fn from critic_train_state isn't actually used (critic_network.apply was used directly instead), which is why this issue was overlooked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
apply_fn in critic_train_state is incorrect and uses the actor apply. fixed it to use the critic one.