fix(config): database models and config client refactor#98
Merged
Conversation
Mortega5
added
the
patch
Mortega5
force-pushed
the
fix/config-models
branch
from
80662ac to
989126d
Compare
wistefan
requested changes
May 7, 2026
Collaborator
wistefan
left a comment
wistefan
left a comment
There was a problem hiding this comment.
Looks good, but can you please add back the removed documentation in the configClient.go?
wistefan
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
database/models.gofor better separation of concernsCredentialServiceto align with the CCS implementation formatcreateServiceverifier to match the previous implementation behaviourpresentationDefinition.formatstruct andinputDescriptionformat presentationoptionalfield inFields: when absent in JSON, now correctly defaults totrueinstead offalse