Stop model when using use_cavity=false with cavity mesh#873
Open
Stop model when using use_cavity=false with cavity mesh#873
Conversation
Collaborator
|
I agree this is a good first step. I think the medium term goal should be to have the model behave as expected. I.e. which setting cavity = false, the cavity areas are treated as land, not as open ocean. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raise an error and stop the model when the mesh folder contains cavity mesh files (cavity_elvls.out) but the user set
use_cavity=.false.in namelist.config to prevent cavity grid cells being unintendedly treated as open ocean. #872