sparseframe: add optional smoothing to sparse_localmax - #622
Merged
Conversation
Fixes FABLE-3DXRD#159. SparseScan.lmlabel already smooths via cImageD11.sparse_smooth before localmax labelling, but the frame-level equivalent sparse_localmax() had no way to do the same. Adds a smooth=False kwarg (default keeps existing behaviour/output unchanged) that reuses the existing sparse_smooth helper, same as SparseScan.lmlabel already does.
Member
Author
|
I think there is zero test coverage for this. Lets add a test please |
Addresses review feedback on FABLE-3DXRD#622 (no test coverage for the new smooth= parameter). Checks that sparse_localmax(frame, smooth=...) reproduces the per-frame labelling that SparseScan.lmlabel(smooth=...) already computes internally, for both smooth=True and smooth=False, using the silicon sparse test data in test/pixelmapper/. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #159. SparseScan.lmlabel already smooths via cImageD11.sparse_smooth before localmax labelling, but the frame-level equivalent sparse_localmax() had no way to do the same. Adds a smooth=False kwarg (default keeps existing behaviour/output unchanged) that reuses the existing sparse_smooth helper, same as SparseScan.lmlabel already does.