Store pbp peak index as a group inside the icolf file - #617
Merged
jonwright merged 1 commit intoSep 6, 2026
Merged
Conversation
The voxel_mask peak index is a lookup/partition table for the icolf it accompanies, so store it as the PBPPeakIndex group in the same HDF5 file instead of a sibling _pbpindex.h5 sidecar file. The peaks group is left untouched; mmap_h5colf and colfile_from_hdf find columns by ImageD11_type, so the extra group does not confuse them. Remove default_index_filename and the PBP.index_filename attribute / point_by_point index_filename parameter; the partition is now always read from the icolf file in the initializer, warm-up and SLURM chunk worker.
Contributor
|
seems good to me. I have something similar but not pushed. happy to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TEST THIS BEFORE MERGING: AI WRITTEN CODE
The voxel_mask peak index is a lookup/partition table for the icolf it accompanies, so store it as the PBPPeakIndex group in the same HDF5 file instead of a sibling _pbpindex.h5 sidecar file. The peaks group is left untouched; mmap_h5colf and colfile_from_hdf find columns by ImageD11_type, so the extra group does not confuse them.
Remove default_index_filename and the PBP.index_filename attribute / point_by_point index_filename parameter; the partition is now always read from the icolf file in the initializer, warm-up and SLURM chunk worker.