Conversation
melvin-bot
Bot
requested review from
FitseTLT and
heyjennahay
and removed request for
a team
Contributor
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index f5ac8049..d432d1af 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -4823,8 +4823,9 @@ ${amount} für ${merchant} – ${date}`,
Wenn du für jede Karte einen bestimmten Lieferanten festlegen möchtest, gehe zu *Einstellungen > Domains > Firmenkarten*.
`),
- travelDescription: 'Travel expenses will export as journal entries to the NetSuite account specified below.',
+ travelDescription: 'Reisekosten werden als Journaleinträge in das unten angegebene NetSuite-Konto exportiert.',
},
+ travelDescription: 'Reisekosten werden als Journaleinträge in das unten angegebene NetSuite-Konto exportiert.',
},
expenseReportDestinationConfirmDescription:
'Wenn Sie die Export-Einstellung für Unternehmenskarten auf Spesenabrechnungen umstellen, werden NetSuite-Lieferanten und Buchungskonten für einzelne Karten deaktiviert.\n\nKeine Sorge, wir speichern Ihre bisherigen Auswahlen, falls Sie später wieder zurückwechseln möchten.',
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index f37ceb79..0c466db3 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -4833,8 +4833,9 @@ ${amount} pour ${merchant} - ${date}`,
Si vous souhaitez définir un fournisseur spécifique pour chaque carte, accédez à *Paramètres > Domaines > Cartes d’entreprise*.
`),
- travelDescription: 'Travel expenses will export as journal entries to the NetSuite account specified below.',
+ travelDescription: 'Les frais de voyage seront exportés sous forme d’écritures de journal vers le compte NetSuite indiqué ci-dessous.',
},
+ travelDescription: 'Les frais de voyage seront exportés sous forme d’écritures de journal vers le compte NetSuite indiqué ci-dessous.',
},
expenseReportDestinationConfirmDescription:
'Si vous basculez le paramètre d’exportation de carte société vers les notes de frais, les fournisseurs NetSuite et les comptes de comptabilisation pour les cartes individuelles seront désactivés.\n\nNe vous inquiétez pas, nous conserverons vos sélections précédentes au cas où vous souhaiteriez revenir en arrière plus tard.',
diff --git a/src/languages/it.ts b/src/languages/it.ts
index a0383f4d..fcd2d9f1 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -4807,8 +4807,9 @@ ${amount} per ${merchant} - ${date}`,
Se desideri impostare un fornitore specifico per ogni carta, vai su *Impostazioni > Domini > Carte aziendali*.
`),
- travelDescription: 'Travel expenses will export as journal entries to the NetSuite account specified below.',
+ travelDescription: 'Le spese di viaggio verranno esportate come registrazioni contabili sull’account NetSuite specificato di seguito.',
},
+ travelDescription: 'Le spese di viaggio verranno esportate come registrazioni contabili sull’account NetSuite specificato di seguito.',
},
expenseReportDestinationConfirmDescription:
'Se passi l’impostazione di esportazione delle carte aziendali a note spese, i fornitori NetSuite e i conti di registrazione per le singole carte verranno disabilitati.\n\nNon preoccuparti, salveremo comunque le tue selezioni precedenti nel caso volessi tornare indietro più tardi.',
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 86aec4dc..8a2e4090 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -4765,8 +4765,9 @@ ${integrationName === CONST.ONBOARDING_ACCOUNTING_MAPPING.other ? 'あなたの'
各カードごとに特定の取引先を設定したい場合は、*設定 > ドメイン > 会社カード* に移動してください。
`),
- travelDescription: 'Travel expenses will export as journal entries to the NetSuite account specified below.',
+ travelDescription: '出張費は、以下で指定された NetSuite アカウントに仕訳としてエクスポートされます。',
},
+ travelDescription: '出張費は、以下で指定された NetSuite アカウントに仕訳としてエクスポートされます。',
},
expenseReportDestinationConfirmDescription:
'会社カードのエクスポート設定を経費レポートに切り替えると、個々のカードに対するNetSuiteのベンダーおよび転記勘定は無効になります。\n\nご安心ください。後で元に戻したくなった場合に備えて、以前の選択内容は引き続き保存されます。',
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 1ff76699..d6051ceb 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -4800,8 +4800,9 @@ ${amount} voor ${merchant} - ${date}`,
Als je voor elke kaart een specifieke leverancier wilt instellen, ga dan naar *Instellingen > Domeinen > Bedrijfspassen*.
`),
- travelDescription: 'Travel expenses will export as journal entries to the NetSuite account specified below.',
+ travelDescription: 'Reiskosten worden geëxporteerd als journaalposten naar de hieronder opgegeven NetSuite-rekening.',
},
+ travelDescription: 'Reiskosten worden geëxporteerd als journaalposten naar de hieronder opgegeven NetSuite-rekening.',
},
expenseReportDestinationConfirmDescription:
'Als je de exportinstelling voor bedrijfskaarten wijzigt naar onkostendeclaraties, worden NetSuite-leveranciers en boekingsrekeningen voor individuele kaarten uitgeschakeld.\n\nMaak je geen zorgen, we bewaren je vorige selecties voor het geval je later weer wilt terugschakelen.',
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index 9c1a8a57..3ec1d290 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -4791,8 +4791,9 @@ ${amount} dla ${merchant} - ${date}`,
Jeśli chcesz ustawić konkretnego dostawcę dla każdej karty, przejdź do *Ustawienia > Domeny > Karty firmowe*.
`),
- travelDescription: 'Travel expenses will export as journal entries to the NetSuite account specified below.',
+ travelDescription: 'Wydatki na podróże służbowe zostaną wyeksportowane jako zapisy księgowe na konto NetSuite wskazane poniżej.',
},
+ travelDescription: 'Wydatki na podróże służbowe zostaną wyeksportowane jako zapisy księgowe na konto NetSuite wskazane poniżej.',
},
expenseReportDestinationConfirmDescription:
'Jeśli zmienisz ustawienie eksportu firmowych kart płatniczych na raporty wydatków, dostawcy NetSuite i konta księgowe przypisane do poszczególnych kart zostaną wyłączone.\n\nNie martw się, nadal zachowamy Twoje poprzednie wybory na wypadek, gdybyś później chciał(a) wrócić do poprzednich ustawień.',
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index a10c94d0..1230941d 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -4794,8 +4794,9 @@ ${amount} para ${merchant} - ${date}`,
Se quiser definir um fornecedor específico para cada cartão, vá em *Configurações > Domínios > Cartões Corporativos*.
`),
- travelDescription: 'Travel expenses will export as journal entries to the NetSuite account specified below.',
+ travelDescription: 'As despesas de viagem serão exportadas como lançamentos contábeis para a conta NetSuite especificada abaixo.',
},
+ travelDescription: 'As despesas de viagem serão exportadas como lançamentos contábeis para a conta NetSuite especificada abaixo.',
},
expenseReportDestinationConfirmDescription:
'Se você alterar a configuração de exportação de cartão corporativo para relatórios de despesas, os fornecedores do NetSuite e as contas de lançamento para cartões individuais serão desativados.\n\nNão se preocupe, ainda vamos salvar suas seleções anteriores caso queira voltar para a configuração anterior depois.',
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index 314ae4af..9c37125a 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -4685,8 +4685,9 @@ ${amount}，商户：${merchant} - 日期：${date}`,
如果你希望为每张卡设置特定供应商，请前往 *设置 > 域 > 公司卡*。
`),
- travelDescription: 'Travel expenses will export as journal entries to the NetSuite account specified below.',
+ travelDescription: '差旅报销将作为日记账分录导出到下方指定的 NetSuite 账户。',
},
+ travelDescription: '差旅报销将作为日记账分录导出到下方指定的 NetSuite 账户。',
},
expenseReportDestinationConfirmDescription:
'如果您将公司卡导出设置切换为报销单，单张卡片对应的 NetSuite 供应商和入账科目将被停用。\n\n别担心，我们会继续保存您之前的选择，以便您日后需要时切换回去。',
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Contributor
|
@blimpich Let me know if I should review or remove me from reviewers list Thx |
Contributor
Author
|
No need for review, thank you @FitseTLT ! |
Contributor
Author
|
asking for spanish copy confirmation here: https://expensify.slack.com/archives/C01GTK53T8Q/p1777576469912859 |
blimpich
requested review from
rlinoz and
stitesExpensify
and removed request for
rlinoz
Contributor
Author
|
updated spanish copy after confirmation |
marcaaron
approved these changes
Apr 30, 2026
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
|
🚧 @blimpich has triggered a test Expensify/App build. You can view the workflow run here. |
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
Contributor
|
🚀 Deployed to staging by https://github.com/blimpich in version: 9.3.65-0 🚀
Bundle Size Analysis (Sentry): |
Draft
2 tasks
Contributor
|
🤖 Docs review complete. Changes in this PR do require a help site update. What changed: The PR moves the Travel Invoicing setting higher on the NetSuite export configuration page and adds an explicit "Export as: Journal entries" display on the Travel Invoicing sub-page. The existing help site doc ( Draft PR created: #89328
Note: I was unable to add the PR to GitHub project 196 due to token permissions. Please add it manually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Addresses two UX issues with the NetSuite Travel Invoicing export setting. See this slack thread for details.
Here's what changed:
Adds a
travelDescriptiontranslation key to all 10 language filesFixed Issues
$ https://github.com/Expensify/Expensify/issues/631291
PROPOSAL:
Tests
Offline tests
N/A — UI-only reordering and display change.
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Screen.Recording.2026-04-30.at.12.02.41.PM.mov