Fix missing empty Reports create report CTA after test drive#88604
Open
emkhalid wants to merge 3 commits intoExpensify:mainfrom
Open
Fix missing empty Reports create report CTA after test drive#88604emkhalid wants to merge 3 commits intoExpensify:mainfrom
emkhalid wants to merge 3 commits intoExpensify:mainfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 74a6cea6f8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
This PR fixes the empty Reports state after test drive for brand-new users who do not have a report-capable workspace yet.
Previously,
EmptySearchViewonly rendered the inlineCreate reportbutton whengroupPoliciesWithChatEnabled.length > 0, so users could see the post-test-drive instruction to create a report but no button at all.This change shows the inline
Create reportbutton wheneverhasSeenTouris true, and routes users with no valid workspace into the existing Reports upgrade flow.Fixed Issues
$ #87477
PROPOSAL: #87477 (comment)
Tests
Get paid back by my employer.Search>Reports.Take a test driveand does not show the greenCreate reportbutton yet.Take a test driveand complete/close the test drive.Search>Reports.Use the green button below to create a report.and a greenCreate reportbutton is visible.Create report.Select a workspace.Offline tests
N/A - this change only affects client-side CTA visibility and route selection in the empty Reports state. It does not introduce new offline-specific behavior.
QA Steps
Same as Tests
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android-native-create-report-fix.mp4
Android: mWeb Chrome
android-web-create-report-fix.mp4
iOS: Native
ios-native-create-report-fix.mp4
iOS: mWeb Safari
ios-web-create-report-fix.mp4
MacOS: Chrome / Safari
create-report-fix.mp4