Part 2 - Thread `personalDetailsList` param through `isOptimisticPersonalDetail` + `isTestTransactionReport` chains by Krishna2323 · Pull Request #87825 · Expensify/App

Krishna2323 · 2026-04-13T23:20:26Z

Explanation of Change

Fixed Issues

$ #66413
PROPOSAL:

Tests

isOptimisticPersonalDetail / shouldDisableDetailPage:

Log in to the app
Open any 1:1 DM chat
Tap the chat header to open the report details page
Verify the details page loads correctly and is not disabled
Go offline
Send a message to a brand new user (who hasn't signed up yet)
Verify the chat opens and the header shows correctly (optimistic personal detail scenario)
Tap the header — verify the chat header is correctly disabled (not clickable) for the optimistic participant
Go back online and verify the chat header becomes clickable once real personal details arrive.

isTestTransactionReport / buildOptimisticReportPreview:

Submit a new expense to another user (e.g. manual expense for $10)
Verify the report preview message appears correctly in the chat
Open the expense report and verify it displays without errors
If you have access to a test drive account (mctest), verify the test transaction badge behavior is correct

General:

Open a split expense and verify the report preview renders correctly
Verify no errors or crashes throughout

Verify that no errors appear in the JS console

Offline tests

Same as Tests

QA Steps

Same as Tests
Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Monosnap.screencast.2026-04-14.19-35-36.mp4

Monosnap.screencast.2026-04-14.19-42-15.mp4

…sableDetailPage, isTestTransactionReport, and buildOptimisticReportPreview Signed-off-by: krishna2323 <[email protected]>

Krishna2323 · 2026-04-13T23:21:49Z

@codex review

codecov · 2026-04-13T23:31:06Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
...gineProvider/HTMLRenderers/UserDetailsRenderer.tsx	`75.00% <100.00%> (ø)`
src/libs/actions/IOU/Hold.ts	`93.59% <ø> (ø)`
src/libs/actions/IOU/PerDiem.ts	`69.32% <100.00%> (ø)`
src/libs/actions/IOU/SendInvoice.ts	`95.96% <100.00%> (ø)`
src/libs/actions/IOU/TrackExpense.ts	`80.13% <100.00%> (ø)`
src/libs/actions/IOU/index.ts	`83.28% <100.00%> (-0.11%)`	⬇️
src/libs/actions/Policy/Member.ts	`74.48% <100.00%> (ø)`
src/libs/actions/Report/index.ts	`69.24% <100.00%> (ø)`
src/pages/inbox/HeaderView.tsx	`95.95% <100.00%> (+0.08%)`	⬆️
src/pages/inbox/report/ReportActionItemCreated.tsx	`100.00% <100.00%> (ø)`
... and 6 more
... and 6 files with indirect coverage changes

chatgpt-codex-connector · 2026-04-13T23:31:51Z

Codex Review: Didn't find any major issues. Chef's kiss.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Signed-off-by: krishna2323 <[email protected]>

…portPreview and standardize TODO comments Signed-off-by: krishna2323 <[email protected]>

melvin-bot · 2026-04-14T14:13:53Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-04-14T14:14:03Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

flaviadefaria · 2026-04-14T18:41:56Z

No new product considerations - removing my assignment and unsubscribing.

github-actions · 2026-04-15T21:20:04Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

Signed-off-by: krishna2323 <[email protected]>

Krishna2323 · 2026-04-15T21:24:08Z

@codex review

chatgpt-codex-connector · 2026-04-15T21:33:29Z

Codex Review: Didn't find any major issues. 🚀

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Krishna2323 · 2026-04-17T08:16:19Z

@DylanDylann friendly bump

…entry and use selector at call sites Signed-off-by: krishna2323 <[email protected]>

Signed-off-by: krishna2323 <[email protected]>

chatgpt-codex-connector · 2026-04-20T20:14:01Z

To use Codex here, create a Codex account and connect to github.

Krishna2323 · 2026-04-20T20:14:17Z

@codex review

chatgpt-codex-connector · 2026-04-20T20:35:42Z

Codex Review: Didn't find any major issues. Hooray!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

…rDetailsRenderer Signed-off-by: krishna2323 <[email protected]>

Krishna2323 · 2026-04-23T19:09:46Z

@codex review

chatgpt-codex-connector · 2026-04-23T19:20:24Z

Codex Review: Didn't find any major issues. 🚀

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

…an in UserDetailsRenderer Signed-off-by: krishna2323 <[email protected]>

Krishna2323 · 2026-04-23T19:37:57Z

@DylanDylann all comments addressed

DylanDylann · 2026-04-25T09:06:39Z

    const styles = useThemeStyles();
-    const accountID = tnode.attributes.accountid ? parseInt(tnode.attributes.accountid, 10) : undefined;
+    const accountID = tnode.attributes.accountid ? parseInt(tnode.attributes.accountid, 10) : CONST.DEFAULT_NUMBER_ID;
+    const [isOptimistic] = useOnyx(ONYXKEYS.PERSONAL_DETAILS_LIST, {selector: (list) => isOptimisticPersonalDetail(accountID, list?.[accountID])});


Please write a selector function into the selector folder. The isOptimisticPersonalDetail function should be removed, I think personalDetail?.isOptimisticPersonalDetail is enough

DylanDylann · 2026-04-25T09:14:51Z

    }

-    const shouldDisableDetailPage = shouldDisableDetailPageReportUtils(report);
+    const shouldDisableDetailPage = shouldDisableDetailPageReportUtils(report, personalDetailsList);


I think we should optimize to avoid passing a large parameter. Actually, we only use one field of one personal detail

…tead of full list Signed-off-by: krishna2323 <[email protected]>

Krishna2323 · 2026-04-25T21:00:34Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8c1b9fa741

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

…oolean Signed-off-by: krishna2323 <[email protected]>

Krishna2323 · 2026-04-25T21:50:33Z

@codex review

chatgpt-codex-connector · 2026-04-25T22:00:38Z

Codex Review: Didn't find any major issues. 🎉

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Add personalDetailsList param to isOptimisticPersonalDetail, shouldDi…

011b06d

…sableDetailPage, isTestTransactionReport, and buildOptimisticReportPreview Signed-off-by: krishna2323 <[email protected]>

melvin-bot Bot assigned Krishna2323 Apr 13, 2026

Krishna2323 added 2 commits April 14, 2026 19:16

Standardize TODO comments to name the fallback function and target PR

08f5ed2

Signed-off-by: krishna2323 <[email protected]>

Move personalDetailsList before defaulted params in buildOptimisticRe…

a1a7b72

…portPreview and standardize TODO comments Signed-off-by: krishna2323 <[email protected]>

Krishna2323 marked this pull request as ready for review April 14, 2026 14:13

Krishna2323 requested review from a team as code owners April 14, 2026 14:13

melvin-bot Bot requested review from a team, DylanDylann and flaviadefaria and removed request for a team and DylanDylann April 14, 2026 14:13

melvin-bot Bot requested review from DylanDylann and removed request for a team April 14, 2026 14:14

Krishna2323 mentioned this pull request Apr 14, 2026

[Due for payment 2026-04-28] Remove Onyx.connect() for the key: ONYXKEYS.PERSONAL_DETAILS_LIST in src/libs/ReportUtils.ts #66413

Open

flaviadefaria removed their request for review April 14, 2026 18:41

Krishna2323 force-pushed the krishna2323/issue/66413/part-2 branch from b61063d to a1a7b72 Compare April 15, 2026 21:19

Krishna2323 requested review from a team and stephanieelliott as code owners April 15, 2026 21:19

Merge branch 'main' into krishna2323/issue/66413/part-2

c49a0a7

Signed-off-by: krishna2323 <[email protected]>

Krishna2323 force-pushed the krishna2323/issue/66413/part-2 branch from 39ba12c to c49a0a7 Compare April 15, 2026 21:23

stephanieelliott removed their request for review April 16, 2026 06:33

Merge branch 'Expensify:main' into krishna2323/issue/66413/part-2

c326dda

Merge branch 'Expensify:main' into krishna2323/issue/66413/part-2

12d68dd

DylanDylann reviewed Apr 20, 2026

View reviewed changes

Comment thread src/libs/ReportUtils.ts Outdated

Krishna2323 added 2 commits April 21, 2026 01:39

Narrow isOptimisticPersonalDetail to accept a single PersonalDetails …

6fcc952

…entry and use selector at call sites Signed-off-by: krishna2323 <[email protected]>

fix lint.

4078e88

Signed-off-by: krishna2323 <[email protected]>

This comment was marked as duplicate.

Sign in to view

DylanDylann reviewed Apr 21, 2026

View reviewed changes

Comment thread src/components/HTMLEngineProvider/HTMLRenderers/UserDetailsRenderer.tsx Outdated

DylanDylann reviewed Apr 21, 2026

View reviewed changes

Comment thread src/libs/ReportUtils.ts Outdated

Krishna2323 added 2 commits April 24, 2026 00:09

Merge branch 'Expensify:main' into krishna2323/issue/66413/part-2

c3548b9

Narrow params to single PersonalDetails entry and use selector in Use…

d9c1c62

…rDetailsRenderer Signed-off-by: krishna2323 <[email protected]>

Narrow params to single PersonalDetails and select isOptimistic boole…

da21898

…an in UserDetailsRenderer Signed-off-by: krishna2323 <[email protected]>

DylanDylann reviewed Apr 25, 2026

View reviewed changes

Krishna2323 added 2 commits April 26, 2026 01:14

Merge branch 'Expensify:main' into krishna2323/issue/66413/part-2

8e4c2bc

Use selector and narrow shouldDisableDetailPage to accept boolean ins…

8c1b9fa

…tead of full list Signed-off-by: krishna2323 <[email protected]>

chatgpt-codex-connector Bot reviewed Apr 25, 2026

View reviewed changes

Comment thread src/pages/inbox/HeaderView.tsx Outdated

Accept single PersonalDetails in shouldDisableDetailPage instead of b…

bff628e

…oolean Signed-off-by: krishna2323 <[email protected]>

Conversation

Krishna2323 commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

Krishna2323 commented Apr 13, 2026

Uh oh!

codecov Bot commented Apr 13, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

chatgpt-codex-connector Bot commented Apr 13, 2026

Uh oh!

melvin-bot Bot commented Apr 14, 2026

Uh oh!

melvin-bot Bot commented Apr 14, 2026

Uh oh!

flaviadefaria commented Apr 14, 2026

Uh oh!

github-actions Bot commented Apr 15, 2026

Uh oh!

Krishna2323 commented Apr 15, 2026

Uh oh!

chatgpt-codex-connector Bot commented Apr 15, 2026

Uh oh!

Krishna2323 commented Apr 17, 2026

Uh oh!

Uh oh!

This comment was marked as duplicate.

chatgpt-codex-connector Bot commented Apr 20, 2026

Uh oh!

Krishna2323 commented Apr 20, 2026

Uh oh!

chatgpt-codex-connector Bot commented Apr 20, 2026

Uh oh!

Uh oh!

Uh oh!

Krishna2323 commented Apr 23, 2026

Uh oh!

chatgpt-codex-connector Bot commented Apr 23, 2026

Uh oh!

Krishna2323 commented Apr 23, 2026

Uh oh!

DylanDylann Apr 25, 2026

Choose a reason for hiding this comment

Uh oh!

DylanDylann Apr 25, 2026

Choose a reason for hiding this comment

Uh oh!

Krishna2323 commented Apr 25, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Krishna2323 commented Apr 25, 2026

Uh oh!

chatgpt-codex-connector Bot commented Apr 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Krishna2323 commented Apr 13, 2026 •

edited

Loading

codecov Bot commented Apr 13, 2026 •

edited by github-actions Bot

Loading