Fix : Reports - Create report button does not show upgrade page when account has no workspace by M00rish · Pull Request #78995 · Expensify/App

M00rish · 2026-01-07T12:06:21Z

Explanation of Change

Fixed Issues

$ #73762
PROPOSAL:
comment

Tests

Precondition: Account has self DM and no workspace

Go to self DM
Create an expense
Go to Reports > Expenses
Select the expense via checkbox
Click dropdown menu > Move expense > create
verify Upgrade page opens
verify when go back you land at previous screen (create menu)
verify when confirm new workspace the expense get moved.
verify bulk move work

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android.webm

Android: mWeb Chrome

AndroidWeb.webm

iOS: Native

ios.webm

iOS: mWeb Safari

iosWeb.webm

MacOS: Chrome / Safari

web.webm

codecov · 2026-01-07T12:15:49Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...rc/pages/workspace/upgrade/UpgradeConfirmation.tsx	`72.22% <100.00%> (ø)`
...rc/pages/Search/SearchTransactionsChangeReport.tsx	`0.00% <0.00%> (ø)`
...c/pages/iou/request/step/IOURequestStepUpgrade.tsx	`0.00% <0.00%> (ø)`
... and 9 files with indirect coverage changes

melvin-bot · 2026-01-29T07:11:52Z

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2026-01-29T07:13:19Z


    const description = useMemo(() => {
-        if (isCategorizing ?? isReporting) {
+        if (isCategorizing || isReporting) {


❌ CONSISTENCY-2

The ?? operator was likely intentional for null/undefined checking, but || treats falsy values differently (including false, 0, ""). If isCategorizing or isReporting are explicitly false, this will incorrectly fall through to the condition.

Suggested fix: Keep the nullish coalescing operator if the intent was to only check for null/undefined:

if (isCategorizing ?? isReporting) {

Or if you intended OR logic, use explicit checks:

if (isCategorizing || isReporting) {

Note: This appears to be a logical change rather than just a style fix - ensure the new behavior is correct.

Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: db5cf3efa9

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-01-29T07:19:39Z

+                policy: newPolicy,
+                reportNextStep,
+                policyCategories: allPolicyCategories?.[`${ONYXKEYS.COLLECTION.POLICY_CATEGORIES}${policyID}`],
+                allTransactions,
+            });


Pass selected transactions data to bulk move

In this upgrade flow you pass allTransactions from the Onyx TRANSACTION collection into changeTransactionsReport, but the selected items here come from SearchContext (snapshot search results) and aren’t guaranteed to exist in that Onyx collection. changeTransactionsReport filters missing entries and returns early when none are found, so the post-upgrade bulk move can become a no-op for search-based selections. Consider building the allTransactions map from selectedTransactions (as the search change-report flow does) or otherwise ensuring the selected IDs are present before calling.

Useful? React with 👍 / 👎.

…ort in IOURequestStepUpgrade

shubham1206agra · 2026-02-06T11:26:14Z

@M00rish Please fix errors

M00rish · 2026-02-09T06:02:31Z

Done @shubham1206agra

M00rish · 2026-03-11T07:49:30Z

looks good on my end @ShridharGoel

ShridharGoel · 2026-04-03T16:16:03Z

Can you merge main here?

ShridharGoel · 2026-04-03T16:16:31Z

looks good on my end

Did you try with offline mode?

M00rish · 2026-04-16T12:05:53Z

I think i did will test again today

M00rish · 2026-04-21T12:53:35Z

@ShridharGoel would you check again? you were right, offline was the problem, it's fixed.

ShridharGoel · 2026-04-25T22:37:10Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-04-26.at.8.51.35.PM.mov

Android: mWeb Chrome

Screen.Recording.2026-04-26.at.8.53.49.PM.mov

iOS: HybridApp

Screen.Recording.2026-04-26.at.8.41.08.PM.mov

iOS: mWeb Safari

Screen.Recording.2026-04-26.at.8.45.15.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2026-04-26.at.8.37.10.PM.mov

github-actions · 2026-04-27T21:28:40Z

🚧 @deetergp has triggered a test Expensify/App build. You can view the workflow run here.

PR #78995 added a changeTransactionsReport() call in IOURequestStepUpgrade but omitted the required policyTagList field, breaking typecheck on main. Fixes #88997

github-actions · 2026-04-27T21:38:15Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #78995.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-d5194a4-fa958c6-222d9fddaaf21b776b5803a94ff012f820c948e0/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-d5194a4-fa958c6-64ed0ec76842378a0eaf5e7e4284ce5cb21c5db9/index.html

Web 🕸️
https://78995.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-04-28T00:16:20Z

🚀 Deployed to staging by https://github.com/deetergp in version: 9.3.62-13 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-04-28T00:18:50Z

After reviewing the changes in this PR and the existing help site documentation, no help site updates are required.

Reasoning:

This PR fixes a bug where the "Create report" button didn't show an upgrade page when the user had no workspace. It adds the missing upgrade navigation path and handles bulk-moving expenses after workspace creation.
The relevant help site articles (Managing Expenses in a Report, Getting Started with the Reports Page, Create and Submit Reports) describe the move/create-report workflow at a high level without documenting intermediate UI screens like the upgrade prompt.
Since this is a bug fix for a broken edge case (not a new user-facing feature), and the documented end-user workflow remains unchanged, no documentation updates are needed.

OSBotify · 2026-04-28T01:04:01Z

🚀 Deployed to staging by https://github.com/deetergp in version: 9.3.63-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

Bundle Size Analysis (Sentry):

Android

OSBotify · 2026-04-28T01:34:44Z

🚀 Deployed to staging by https://github.com/deetergp in version: 9.3.64-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

OSBotify · 2026-04-30T22:42:36Z

🚀 Deployed to production by https://github.com/arosiclair in version: 9.3.64-31 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

show upgrade first

be2e732

melvin-bot Bot assigned M00rish Jan 7, 2026

M00rish changed the title ~~show upgrade first~~ Fix : Reports - Create report button does not show upgrade page when account has no workspace Jan 7, 2026

M00rish added 8 commits January 13, 2026 12:25

Merge origin/main into upgradepath

e7255f1

fix bulk move and navigation

47c974e

merge main

a442f00

Merge remote-tracking branch 'origin/main' into upgradepath

6be40c0

Update IOURequestStepUpgrade and UpgradeConfirmation components

d8ec835

Merge branch 'Expensify:main' into upgradepath

df0fb46

lint

0ecce10

Merge branch 'Expensify:main' into upgradepath

db5cf3e

M00rish marked this pull request as ready for review January 29, 2026 07:11

M00rish requested review from a team as code owners January 29, 2026 07:11

melvin-bot Bot requested review from heyjennahay and shubham1206agra and removed request for a team January 29, 2026 07:11

melvin-bot Bot removed the request for review from a team January 29, 2026 07:11

github-actions Bot reviewed Jan 29, 2026

View reviewed changes

chatgpt-codex-connector Bot reviewed Jan 29, 2026

View reviewed changes

M00rish added 4 commits February 6, 2026 03:44

Fix selectedTransactions not properly passed to changeTransactionsRep…

e861d89

…ort in IOURequestStepUpgrade

lint

2f2628c

Fix TypeScript errors: add null check and remove extra false arg

9cbf2d2

Merge branch 'Expensify:main' into upgradepath

cce4c9a

M00rish added 2 commits February 8, 2026 23:34

fix: add missing betas parameter to createNewReport call

e56d95f

Merge branch 'Expensify:main' into upgradepath

5f10d0c

M00rish added 2 commits March 11, 2026 06:27

Merge branch 'Expensify:main' into upgradepath

2dd9072

resolve conflict

fc8b21b

M00rish added 3 commits April 20, 2026 04:26

Merge branch 'Expensify:main' into upgradepath

1017ec2

fix nextstep message

b247b49

Merge branch 'Expensify:main' into upgradepath

4b98bde

ShridharGoel approved these changes Apr 26, 2026

View reviewed changes

melvin-bot Bot requested a review from deetergp April 26, 2026 15:27

deetergp approved these changes Apr 27, 2026

View reviewed changes

deetergp merged commit d5194a4 into Expensify:main Apr 27, 2026
39 checks passed

github-actions Bot mentioned this pull request Apr 27, 2026

[Due for payment 2026-05-07] Investigate workflow job failing on main: typecheck / typecheck #88997

Closed

deetergp mentioned this pull request Apr 27, 2026

[No QA] Fix: add missing policyTagList arg in changeTransactionsReport call #88998

Closed

52 tasks

MelvinBot mentioned this pull request Apr 27, 2026

[CP Staging] Re-fire search on Spend tab focus after cache clear #88994

Merged

52 tasks

OSBotify mentioned this pull request Apr 28, 2026

Deploy Checklist: New Expensify 2026-04-23 #88633

Closed

jponikarchuk mentioned this pull request Apr 28, 2026

[Exploratory] Spend - Missing merchant violation and draft status is not shown in offline #89065

Open

7 tasks

arosiclair mentioned this pull request Apr 29, 2026

PR checklist #89226

Closed

melvin-bot Bot mentioned this pull request Apr 30, 2026

[Due for payment 2026-05-07] [$250] Reports - Create report button does not show upgrade page when account has no workspace #73762

Open

16 tasks

Conversation

M00rish commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Jan 7, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Jan 29, 2026

Uh oh!

github-actions Bot Jan 29, 2026

Choose a reason for hiding this comment

❌ CONSISTENCY-2

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

shubham1206agra commented Feb 6, 2026

Uh oh!

M00rish commented Feb 9, 2026

Uh oh!

M00rish commented Mar 11, 2026

Uh oh!

ShridharGoel commented Apr 3, 2026

Uh oh!

ShridharGoel commented Apr 3, 2026

Uh oh!

M00rish commented Apr 16, 2026

Uh oh!

M00rish commented Apr 21, 2026

Uh oh!

ShridharGoel commented Apr 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

github-actions Bot commented Apr 27, 2026

Uh oh!

github-actions Bot commented Apr 27, 2026

Uh oh!

OSBotify commented Apr 28, 2026

Uh oh!

MelvinBot commented Apr 28, 2026

Uh oh!

OSBotify commented Apr 28, 2026

Uh oh!

OSBotify commented Apr 28, 2026

Uh oh!

OSBotify commented Apr 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

M00rish commented Jan 7, 2026 •

edited

Loading

codecov Bot commented Jan 7, 2026 •

edited by github-actions Bot

Loading

ShridharGoel commented Apr 25, 2026 •

edited

Loading