-
Notifications
You must be signed in to change notification settings - Fork 3.5k
feat: Add LocaleContextProvider to App component and update loading l… #78517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add LocaleContextProvider to App component and update loading l… #78517
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@QichenZhu Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Hi @BartekObudzinski, what should I test here? Just reload the app? |
|
LGTM |
|
@QichenZhu Sorry forget to fill steps to reproduce, but basically yes, reload the app and be sure if the app is not in the background. You can also check the time on sentry by checking BootsplashVisibleLocale |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid-native.webmAndroid: mWeb Chromeandroid-web.webmiOS: HybridAppios-native.moviOS: mWeb Safariios-web.movMacOS: Chrome / Safarimac-web.mov |
|
@BartekObudzinski, thanks for the info! Just need to fix the "Fixed Issues" section so the automation will work. |
|
We did not find an internal engineer to review this PR, trying to assign a random engineer to #78515 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/Beamanator in version: 9.2.91-0 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.2.91-1 🚀
|
…ogic
Explanation of Change
Previously, IntlStore.load was called inside useEffect, meaning the entire large component tree had to mount and render before locale data loading even started. By moving IntlStore.load to the render phase, we start loading locale data sooner, without waiting for the component lifecycle to complete. This change reduces splash screen duration, with measurements showing load times dropping from ~325ms to ~87ms
Fixed Issues
$ #76010
PROPOSAL:
Tests
Offline tests
QA Steps
(The time can be mesaure to check BootsplashVisibleLocale)
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2025-12-29.at.12.47.56.mov
Android: mWeb Chrome
Screen.Recording.2025-12-29.at.13.11.09.mov
iOS: Native
Screen.Recording.2025-12-29.at.13.13.46.mov
iOS: mWeb Safari
Screen.Recording.2025-12-29.at.13.14.51.mov
MacOS: Chrome / Safari
Screen.Recording.2025-12-29.at.13.01.44.mov