feat: ensure synchronization of dataloader load calls when batching i… - #2203
Merged
samuelAndalon merged 1 commit intoJul 28, 2026
Merged
Conversation
…s disabled and caching enabled (#2202) ### 📝 Description graphql-java/java-dataloader#241 java-dataloader 6 removed synchronization from DataLoader.load(). For cached loaders with batching disabled, concurrent calls using the same key can both observe a cache miss and invoke the underlying loader before either future is cached. This results in duplicate downstream requests even though callers ultimately receive the same cached future. This change: - Adds an internal SynchronizedDataLoader wrapper that synchronizes both load overloads. - Applies the wrapper only when caching is enabled and batching is disabled. - Adds a coroutine-based regression test verifying concurrent same-key loads invoke the underlying loader once. Co-authored-by: Samuel Vazquez <samvazquez@expediagroup.com>
samuelAndalon
deleted the
feat/10.x.x/ensure-synchronization-dataloader-load
branch
July 28, 2026 22:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
cherry-pick #2202