Default client throws on HTTP errors#60
Merged
Gabriel-Darbord merged 1 commit intodevelopfrom Apr 1, 2026
Merged
Conversation
+ 2 retries
Member
|
This will probably lead to update on the MSR project. But it seems good |
Gabriel-Darbord
added a commit
that referenced
this pull request
Apr 3, 2026
This reverts commit bf0ed4c.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
ZnClient >> systemPolicyon the default client instantiated byGitlabApito enforce HTTP success.The goal is to get clear errors when HTTP requests fail, rather than getting errors when parsing error messages as if it were the entities the API asked for.
This also adds two retry attempts and enforces setting the accepted content type, which should not hurt.