phydm: fix wrong enum type in phydm_clm_racing_ctrl signature - #1
Open
iav wants to merge 1 commit into
Open
Conversation
The clm_lv parameter of phydm_clm_racing_ctrl() was declared as enum phydm_nhm_level, evidently copy-pasted from phydm_nhm_racing_ctrl(). The function handles CLM (Channel Load Measurement) levels and its only caller passes struct clm_para_info.clm_lv, which is enum phydm_clm_level. Both enums are numerically identical, so this is a type-correctness fix with no behavioral change; it resolves a -Wenum-conversion warning. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Author
|
pr merged in upstream Mange#368 |
This was referenced Aug 15, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
phydm_clm_racing_ctrl()declares its level parameter asenum phydm_nhm_level, evidently copy-pasted fromphydm_nhm_racing_ctrl(). The function handles CLM (Channel Load Measurement) levels, and its only caller passesclm_para_info.clm_lv, which isenum phydm_clm_level.This corrects the parameter type to
enum phydm_clm_level.enum phydm_clm_levelandenum phydm_nhm_levelare numerically identical (RELEASE=0, LV_1..LV_4=1..4, MAX_NUM=5), so there is no behavioral change — this is a type-correctness fix that resolves a-Wenum-conversioncompiler warning.