Draft
Conversation
glindstedt
force-pushed
the
push-prlkrowxoomr
branch
from
bc99470 to
303dbd7
Compare
glindstedt
force-pushed
the
push-prlkrowxoomr
branch
3 times, most recently
from
fd23e3f to
59810e4
Compare
glindstedt
force-pushed
the
push-prlkrowxoomr
branch
from
59810e4 to
444afc8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Try to refactor any methods where we hand out mutex guards or references into DashMaps, so even if the caller is in an async context it should be impossible to accidentally cause a deadlock.