Update MMG Free_all and Init_mesh calls to use the latest API and fix Hypre import#700
Open
tmyllaeri wants to merge 1 commit intoElmerCSC:develfrom
Open
Update MMG Free_all and Init_mesh calls to use the latest API and fix Hypre import#700tmyllaeri wants to merge 1 commit intoElmerCSC:develfrom
tmyllaeri wants to merge 1 commit intoElmerCSC:develfrom
Conversation
Author
|
Build tests are failing. At least the Hypre import fails, though locally this seems to work |
Contributor
|
We should probably make some #if's for the old vs. new MMG stuff. The release version is still using the old and if develop is using the new it is difficult to alter between the two otherwise. |
Fix Hypre import
tmyllaeri
force-pushed
the
update-mmg-and-hypre-interfaces
branch
from
216e2b3 to
42f28d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that Elmer compilation fails with the latest version of both Hypre and MMG.
This PR changes the MMG calls to follow the example from MMG "develop"branch: https://github.com/MmgTools/mmg/commits/develop/libexamples/mmg3d/adaptation_example0_fortran/example0_a/main.F90
NOTE: This change is most likely not compatible with MMG master branch which is roughly year outdated from "develop"
HYPRE compilation is fixed by simple changing a single import from "krylov.h" to "_hypre_krylov.h"