Feature: Improve geospatial api surface and add additional bedrock models#42
Open
Zettersten wants to merge 3 commits intoElement84:mainfrom
Conversation
Co-authored-by: erik <[email protected]>
Co-authored-by: erik <[email protected]>
Co-authored-by: erik <[email protected]>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This branch adds geometry validation/area calculation utilities and expands LLM model support with Amazon Titan, Mistral AI, and Cohere models.
Total Changes: 5 files modified, +293 insertions, -2 deletions
Changes by Category
1. Geometry Module Enhancements
File:
src/e84_geoai_common/geometry.py(+73 lines)New Functions
validate_and_fix_geometry(geom: BaseGeometry) -> BaseGeometrybuffer(0)technique for automatic repairapproximate_area_km2(g: BaseGeometry) -> floatMinor Fixes
2. LLM Model Expansion
Files:
src/e84_geoai_common/llm/models/converse/converse.py(+30 lines)src/e84_geoai_common/llm/models/converse/__init__.py(+24 lines)src/e84_geoai_common/llm/models/__init__.py(+24 lines)New Model Constants
Amazon Titan Models
Mistral AI Models
Cohere Models
All new models are:
__all__declarationsCONVERSE_BEDROCK_MODEL_IDSdictionary3. Test Coverage
File:
tests/test_geometry.py(+144 lines)validate_and_fix_geometry()Testsapproximate_area_km2()TestsAPI Impact
New Public APIs
e84_geoai_common.geometry.validate_and_fix_geometry()e84_geoai_common.geometry.approximate_area_km2()