Update facebook-login sdk dep, add warning about facebook-common dep#1868
Update facebook-login sdk dep, add warning about facebook-common dep#1868delaneyb wants to merge 1 commit intoEddyVerbruggen:masterfrom
Conversation
|
Hi @delaneyb . Is there a reasonable way to doctor my local setup to use your installer.js change? We don't really want to upgrade NativeScript versions at the moment (we're on 6.5.3) to use their included Firebase features right now. (Also looking into using firebase npm package directly - but that's intended for web and I'm not sure it'll work with an NS app.) Thanks. |
Hi @brendonwm, You could look at using https://www.npmjs.com/package/patch-package if you don't want to clone/fork and build the plugin. Unfortunately patch-package doesn't play nice with Yarn 2 and I always ran up against issues with Yarn's own |
|
Any progress here ? |
This PR updates the facebook-login android dependency to 11.+. There is no need to separately include facebook-core as it is a subdependency of facebook-login (see https://developers.facebook.com/docs/android/componentsdks & https://mvnrepository.com/artifact/com.facebook.android/facebook-login/11.3.0).
Importantly, the facebook-login version as been restricted to 11.+, as from 12.0.0, its subdependency facebook-common adds a dependency on androidx.fragment 1.3.0, overriding the @nativescript-android's expected ver 1.2.5, which breaks navigation in nested frames - minimal repro here: https://github.com/delaneyb/androidx-fragment-130-repro.