add(ci): signing bin before release#2202
Open
PIKACHUIM wants to merge 6 commits intoEasyTier:mainfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a Windows code-signing step to the release workflow (via Certum SimplySign) so Windows binaries can be signed before drafting a GitHub Release.
Changes:
- Introduces a
sign-windowsjob that downloads Windows artifacts, installs/configures SimplySign, signs.exe/.dll, and uploads “signed” artifacts. - Updates the
releasejob to prefer signed artifacts when present and to include signing status in release notes. - Adds helper scripts for SimplySign installation, registry configuration, and TOTP-based authentication.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 9 comments.
| File | Description |
|---|---|
| .github/workflows/release.yml | Adds signing job, artifact switching logic, and release notes generation. |
| .github/scripts/install-simplysign.sh | Installs SimplySign Desktop MSI on Windows runner. |
| .github/scripts/configure-simplysign-registry.ps1 | Preconfigures HKCU registry settings to make SimplySign login dialog automation-friendly. |
| .github/scripts/Connect-SimplySign-Enhanced.ps1 | Generates TOTP and automates SimplySign login via window focus + SendKeys. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…into dev-signcode
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
29
to
+36
| permissions: | ||
| contents: write | ||
|
|
||
|
|
||
| # SimplySign signing configuration | ||
| CERTUM_OTP_URI: ${{ secrets.CERTUM_OTP_URI }} | ||
| CERTUM_USERNAME: ${{ secrets.CERTUM_USERNAME }} | ||
| CERTUM_EXE_PATH: ${{ secrets.CERTUM_EXE_PATH }} |
Comment on lines
+39
to
+42
| sign-windows: | ||
| name: Sign Windows Artifacts with SimplySign | ||
| runs-on: windows-latest | ||
| continue-on-error: true |
Comment on lines
+141
to
+166
| # Continue regardless of signing result (success, failure, skipped, or cancelled) | ||
| if: ${{ always() && (needs.sign-windows.result == 'success' || needs.sign-windows.result == 'failure' || needs.sign-windows.result == 'cancelled' || needs.sign-windows.result == 'skipped') }} | ||
| steps: | ||
| - | ||
| name: Checkout | ||
| uses: actions/checkout@v5 | ||
|
|
||
| - name: Check signing result | ||
| id: check_signing | ||
| run: | | ||
| echo "Signing job result: ${{ needs.sign-windows.result }}" | ||
| if [ "${{ needs.sign-windows.result }}" = "success" ]; then | ||
| echo "status=signed" >> $GITHUB_OUTPUT | ||
| echo "Windows artifacts were signed successfully" | ||
| else | ||
| echo "status=unsigned" >> $GITHUB_OUTPUT | ||
| echo "Warning: Windows signing was skipped or failed, continuing without signatures" | ||
| fi | ||
|
|
||
| - name: Download signed artifacts (if available) | ||
| uses: actions/download-artifact@v4 | ||
| with: | ||
| name: signed-windows-artifacts | ||
| path: signed_release_assets | ||
| continue-on-error: true | ||
|
|
Comment on lines
+93
to
+105
| foreach ($file in $filesToSign) { | ||
| Write-Host "Signing: $($file.FullName)" | ||
| try { | ||
| # Using signtool with the certificate from SimplySign virtual smart card | ||
| $timestampServer = "http://timestamp.digicert.com" | ||
| & signtool sign /fd SHA256 /tr $timestampServer /td SHA256 /a "$($file.FullName)" | ||
| Write-Host " OK: Signed successfully" | ||
| } catch { | ||
| Write-Host " WARNING: Failed to sign file - $($_.Exception.Message)" | ||
| } | ||
| } | ||
|
|
||
| Write-Host "=== SIGNING COMPLETE ===" |
| Write-Host "Signing: $($file.FullName)" | ||
| try { | ||
| # Using signtool with the certificate from SimplySign virtual smart card | ||
| $timestampServer = "http://timestamp.digicert.com" |
| CERTUM_INSTALLER="SimplySignDesktop.msi" | ||
| echo "Downloading SimplySign Desktop MSI..." | ||
|
|
||
| if curl -L "https://files.certum.eu/software/SimplySignDesktop/Windows/9.3.2.67/SimplySignDesktop-9.3.2.67-64-bit-en.msi" -o "$CERTUM_INSTALLER" --fail --max-time 60; then |
|
|
||
| $Digits = if ($q['digits']) { [int]$q['digits'] } else { 6 } | ||
| $Period = if ($q['period']) { [int]$q['period'] } else { 30 } | ||
| $Algorithm = if ($q['algorithm']) { $q['algorithm'].ToUpper() } else { 'SHA256' } |
Author
|
@copilot apply changes based on the comments in this thread |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
添加了Certum EV Cloud Signing代码签名步骤