Censor non-string elements#77
Merged
Justintime50 merged 5 commits intoEasyPost:masterfrom Dec 8, 2025
Merged
Conversation
Justintime50
reviewed
Nov 7, 2025
Contributor
Author
|
Unit tests have been modified, rather than hitting like Reddit JSON and XML feeds, use snapshots of the r/ProgrammerHumor JSON and RSS feeds stored in this repo. #78 will need to be merged first for the unit tests to pass. |
Member
|
@nwithan8 if you're able, do you mind rebasing master here and we can get this merged in? The static test files have been merged already. |
Contributor
Author
Member
|
@nwithan8 I appreciate the much smaller sample data, thanks! Feel free to rebase and I'll re-review. |
f29001f to
9a8e3a7
Compare
- Fix logic error causing XML inner values to be dropped rather than censored - Add unit test for testing text censoring on HTML data
Justintime50
approved these changes
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #76
Testing
Pull Request Type
Please select the option(s) that are relevant to this PR.