ISO 15118-20 Amd1 AC-DER (DIS) and potentially AC-DER-IEC/SAE (FDIS) support#127
Draft
milindur wants to merge 7 commits intoEVerest:mainfrom
Draft
ISO 15118-20 Amd1 AC-DER (DIS) and potentially AC-DER-IEC/SAE (FDIS) support#127milindur wants to merge 7 commits intoEVerest:mainfrom
milindur wants to merge 7 commits intoEVerest:mainfrom
Conversation
Replace _target_dict with maps access for xmlschema 4.3.1 compat. Fix particle dedup in empty content scan to match by name instead of object identity. Fix off-by-one in generator loops and add bounds guard in particle deletion. Signed-off-by: Christian Andersen <[email protected]>
Signed-off-by: Christian Andersen <[email protected]>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 31 |
| Duplication | 0 |
TIP This summary will be updated as you push new changes. Give us feedback
milindur
force-pushed
the
feature/ac-der-iec-support
branch
2 times, most recently
from
00efaf5 to
3e143a3
Compare
Signed-off-by: Christian Andersen <[email protected]>
…oup types Guard namespace particle replacement to only apply for empty/abstract container types per EXI 8.5.4.1.3.2 (concrete types build grammars from their own content model). Collect all derived types for substitution group expansion per EXI 8.5.4.1.6 (set S must include all reachable element declarations, not just the first). Signed-off-by: Christian Andersen <[email protected]>
…nment Their grammar productions come from the substitution group closure (EXI 8.5.4.1.6), not from namespace imports. Signed-off-by: Christian Andersen <[email protected]>
Sort replacement particles by (name, namespace) instead of name only. Populate namespace on all particle factories and newly created replacement particles so the sort key is consistent. Signed-off-by: Christian Andersen <[email protected]>
Signed-off-by: Christian Andersen <[email protected]>
milindur
force-pushed
the
feature/ac-der-iec-support
branch
from
3e143a3 to
a85cf3e
Compare
Member
|
Very nice 👍 |
Author
Hopefully, I’ll have access to some AC-DER-IEC streams in May. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR adds support for the ISO 15118-20 Amd1 schema for the new DER service(s):
AC-DER was tested with a few pcap files using AC-DER communication (based on the DIS version), but all of them used the same EVSE-side stack and the same EV emulation. Therefore, more tests with additional pcap files would be very welcome.
AC-DER-IEC/SAE is currently untested. The code compiles, but at the moment I do not have access to any AC-DER-IEC/SAE pcap files. Hopefully, this will change in summer, at least for IEC.
I also prepared another feature branch (see https://github.com/milindur/cbexigen/tree/feature/xml-serializer-support-for-decoder) that adds optional XML serialization to the generated decoder. The API is compatible with https://github.com/dspace-group/dsV2Gshark. A modified version of dsV2Gshark with AC-DER/AC-DER-IEC support is also available (see https://github.com/milindur/dsV2Gshark/tree/feature/ac-der-iec-support).
The (manual) tests were performed using the dsV2Gshark plugin mentioned above, as well as a Python-based EXI decoder. This decoder uses the generated EXI C decoder to decode the V2GTP messages in a pcap file, extract the XML from the decoder, and optionally convert it to JSON and print it. It has not yet been pushed to GitHub.
I will do more testing as soon as I get access to more AC-DER or AC-DER-IEC EXI streams.
Issue ticket number and link
Fixes #106.
Fixes #123.
Prepares dspace-group/dsV2Gshark#44.
Checklist before requesting a review