Conversation
…e. Reviewed CF names beginning with A, still B-Z to go
…ns, fix description typos
climbfuji
left a comment
There was a problem hiding this comment.
At first, I was confused of seeing cfname entires when they were identical to the ESM standard name, but I realized that this makes sense. Thanks for weeding through the CF names and adding the matches here.
|
So let me confirm my understanding with this PR:
Is there code in place somewhere to enforce the last statement? Put another way, is there anything (other than human diligence) to prevent someone from accidentally pointing a new ESM name at a CF name that is already pointed to by another ESM name? |
|
@svahl991 You bring up a good point, we should have an automated check for duplicate "cfname" elements, since there should never be duplicates in our dictionary unless we have messed something up. I was going to add a quick check in this PR, but it turns out our current tests aren't in very good shape (#144), so I would like to open a new PR to address this. |
|
@svahl991 I have opened #145 that includes a check for duplicate CF names, which should run automatically with each PR. And with regards to your other questions, I think your understanding is in line with my thinking. The CF names do not cover all our use cases, and we have not "automatically" pulled in all CF names (though we likely would if they were needed). |
|
I'll also note for the record, most ESM names are identical to the equivalent CF names, but a few are different because of divergence decisions we've made in the past few years (e.g. |
nusbaume
left a comment
There was a problem hiding this comment.
Thanks for bringing this in @mkavulich! I had a couple questions which came up while reviewing the PR, but otherwise everything looks good to me.
| <cfname>lwe_snowfall_rate</cfname> | ||
| <type units="mm s-1">real</type> | ||
| </standard_name> | ||
| <standard_name name="lwe_surface_snow" description="Liquid water equivalent surface snow"> |
There was a problem hiding this comment.
I realize this isn't directly related to this PR, but is this variable any different from lwe_thickness_of_surface_snow, which is listed farther down?
| for item in std_name: | ||
| if item.tag == 'type': | ||
| if item.tag == 'cfname': | ||
| snl.write(f" * Equivalent CF name: {item.text}\n") |
There was a problem hiding this comment.
I could definitely be wrong as I am not a Markdown expert, but should this have quotations marks like the standard name and type outputs? For example:
| snl.write(f" * Equivalent CF name: {item.text}\n") | |
| snl.write(f" * `Equivalent CF name`: {item.text}\n") |
Description
This PR updates the XML, schema file, and Metadata files to include and "Equivalent CF name" field, to make it easier for code bases such as JEDI that need to interface with both CF standard names and ESM standard names.
In this process I also found and removed some duplicate names, and moved some names to better sections
Issues
Resolves #108