-
Notifications
You must be signed in to change notification settings - Fork 344
Changes to enable easily turning on CUPiD diagnostics from your CTSM case #3689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…n cime, and add a usermod for CUPiD
…ppens if env_postprocessing.xml hasn't been setup yet
| @@ -0,0 +1,44 @@ | |||
| # QuickStart to Running Diagnostics of your Case with CUPiD (CESM Unified Postprocessing and Diagnostics) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we point to the documentation for running CUPiD via the CESM workflow rather than duplicating and ending up with outdated information?
I'm thinking it would also be good for me to put the land-specific 'cheat sheet' as a docs page for component-specific example of running a STANDALONE version
| ./xmlchange --force CUPID_BASELINE_CASE='$CASE' | ||
| ./xmlchange --force CUPID_BASE_STARTDATE='$RUN_STARTDATE' | ||
| ./xmlchange --force CUPID_BASE_STOP_N='$STOP_N' | ||
| # TODO: Make sure STOP_OPTION is nyears |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding these in now in this PR:
CUPID_CLIMO_N_YEARS
CUPID_CLIMO_START_YEAR
CUPID_BASE_CLIMO_START_YEAR
CUPID_BASE_CLIMO_N_YEARS
.gitmodules
Outdated
| path = tools/CUPiD | ||
| #url = https://github.com/NCAR/CUPiD.git | ||
| url = https://github.com/TeaganKing/CUPiD.git | ||
| #fxtag = v0.4.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tag will need to be updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go through this and figure out which of these should be default settings for ALL CTSM standalone cases—i.e., not just in this usermod. (And also—which of these are already set correctly by default without us in CTSM needing to do anything.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe in cime_config/config_component.xml. But need to check that these would only apply in a standalone CTSM checkout.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been looking at other repositories for other things, but I see this sort of thing in config_compsets.xml for several components.
<entries>
<entry id="RUN_STARTDATE">
<values>
<value compset="1850_">0001-01-01</value>
</values>
</entry>So it looks like that's the sort of thing that can be done. The entry is defined elsewhere, but you can set the value according to the compset as above. I think in our case we want it to be in config_component.xml, so I'll check if it can be added there.
If not we could add %CUPID as part of the CLM compset options. I don't think I like that, but it's probably something to discuss. We do have compsets that set a particular user-mod directory as part of their definition. And this would be doing that same thing here.
|
|
||
| This document has more details on more options and such | ||
|
|
||
| https://docs.google.com/document/d/1ziZWGgaj9FxgR6WRHyCAZnzIc6-4ezqfUDDpQv4MzUI/edit?tab=t.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Point to this:
| And you only need to do it again if the CUPiD environment changes. | ||
|
|
||
| ``` shell | ||
| # Setup the conda environments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here, point to the CUPiD documentation
|
We talked about this in the CTSM SE meeting this morning. I need to move onto other things, so I can't complete everything here. But, here are tasks that we do need:
|
|
A few notes:
|
|
@TeaganKing It should be in both places, I'd think. We want to make sure that whatever we have on the CTSM side does everything necessary. |
Description of changes
The changes that are needed to turn CUPiD diagnostics from a CTSM case.
Specific notes
Contributors other than yourself, if any:
@TeaganKing @samrabin
CTSM Issues Fixed (include github issue #):
Are answers expected to change (and if so in what way)? No
Any User Interface Changes (namelist or namelist defaults changes)? Allows
RUN_POSTPROCESSING==TRUE to be used in CTSM cases
Does this create a need to change or add documentation? Did you do so? Yes
I worked on the README files, but we'll need to add to the User's Guide
Testing performed, if any:
I'm running a single test case to show the workflow. But, there are issues...