Remove unused Faxa_ vars

[anton-seaice]

Description of changes

Removes some unused fields from the CESM fields exchange module,

Specific notes

CMEPS Issues Fixed (include github issue #): closes #644

Are changes expected to change answers? (specify if bfb, different at roundoff, more substantial)
bfb

Any User Interface Changes (namelist or namelist defaults changes)? None

Testing performed

Adhoc tests show no impact from this change, results are bfb with previous results.

[billsacks]

Thanks for this cleanup. It looks like these variables are just sent by datm in ERA5 mode, which doesn't appear to be used in CESM. If they were used, I think some other changes would be needed in this module. So I agree that removing these is the right thing to do.

I'm just waiting for the workflows to complete their testing, then will merge.

[billsacks]

I'm thinking these variables can also be removed from fd_cesm.yaml:

CMEPS/mediator/fd_cesm.yaml

Lines 436 to 445 in 567e184

	- standard_name: Faxa_lat
	alias: mean_laten_heat_flx_atm
	canonical_units: W m-2
	description: atm import to med
	#
	- standard_name: Faxa_sen
	alias: mean_sensi_heat_flx_atm
	canonical_units: W m-2
	description: atm import to med
	#

@anton-seaice and @mvertens - do you agree?

[billsacks]

I see that the failing "scripts regression tests" are unrelated to this PR.

Before merging, I'd like some input/confirmation on the removal of these fields from fd_cesm.yaml (see comment above).

Also, @anton-seaice would you be able to document specific test(s) you ran, so we can have that recorded? If you don't have records of that, I'll run one or more tests so we can have something specific confirming testing that has been done.

[uturuncoglu]

@billsacks @anton-seaice please do not remove those fields from the dictionary which could have downstream affect in CDEPS data modes.

[anton-seaice]

Thanks for this cleanup. It looks like these variables are just sent by datm in ERA5 mode, which doesn't appear to be used in CESM. If they were used, I think some other changes would be needed in this module. So I agree that removing these is the right thing to do.

We actually discovered this because we were trying to get the ERA5 datm working.

By removing them here (CMEPS), it means that the ERA5 datm can advertise then but then they don't get connected and so they aren't needed in the ERA5 streams file.

Also, @anton-seaice would you be able to document specific test(s) you ran, so we can have that recorded? If you don't have records of that, I'll run one or more tests so we can have something specific confirming testing that has been done.

I ran global ACCESS-OM3 at 100km (1deg) and 25km(0.25deg) with the CDEPS JRA forcing for very short tests (6 hours) and confirmed no impact on reproducability with existing output or impacts on determinism (including over restarts). (Links that only mean something to ACCESS people: 1 2 3)

[billsacks]

@uturuncoglu - thanks for clarifying that these are still needed in the field dictionary.

@anton-seaice - thanks for your clarifications, and sorry for introducing confusion on that.