Conversation
otbrown
reviewed
Jul 18, 2025
Collaborator
|
You should add your copyright line to LICENSE.txt too, although on one line please! |
otbrown
reviewed
Jul 21, 2025
Collaborator
otbrown
left a comment
otbrown
left a comment
There was a problem hiding this comment.
TODO before merging:
- Minor tidying up of examples.
- Moving useful utility functions/macros to utils.h.
- Update LICENSE.txt.
TODO after merging:
- Abstract hardware details.
- qreg -> qubit array, and possibly use qubits instead of
qreg_id. - Clarify split between device and host functions.
- Add BLAS.
Collaborator
There was a problem hiding this comment.
Do we need an analog qubit type as well as analog qreg?
Collaborator
There was a problem hiding this comment.
Or possibly instead of as an analog qreg is really just an array of analog qubits.
Collaborator
There was a problem hiding this comment.
I'm impressed, but post-merge, we should add BLAS as a dependency!
Renamed executor handle to fit the example. Co-authored-by: Oliver Thomson Brown <otbrown@users.noreply.github.com>
Updated funciton calls to fit new variable nameing. Co-authored-by: Oliver Thomson Brown <otbrown@users.noreply.github.com>
Updated function calls to use new variable names. Co-authored-by: Oliver Thomson Brown <otbrown@users.noreply.github.com>
Renamed the variables to fit the example better. Co-authored-by: Oliver Thomson Brown <otbrown@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introducing analogue extension to CQ.
Users can:
Future work: