Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/FakeXrmEasy.Core/Query/QueryExpressionExtensions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -73,14 +73,14 @@

var linkedEntities = new Dictionary<string, int>();

bool hasAggregates = false;

Check warning on line 76 in src/FakeXrmEasy.Core/Query/QueryExpressionExtensions.cs

View workflow job for this annotation

GitHub Actions / build-windows (FAKE_XRM_EASY_2016)

The variable 'hasAggregates' is assigned but its value is never used

Check warning on line 76 in src/FakeXrmEasy.Core/Query/QueryExpressionExtensions.cs

View workflow job for this annotation

GitHub Actions / build-windows (FAKE_XRM_EASY_2016)

The variable 'hasAggregates' is assigned but its value is never used

Check warning on line 76 in src/FakeXrmEasy.Core/Query/QueryExpressionExtensions.cs

View workflow job for this annotation

GitHub Actions / build-windows (FAKE_XRM_EASY_2013)

The variable 'hasAggregates' is assigned but its value is never used

Check warning on line 76 in src/FakeXrmEasy.Core/Query/QueryExpressionExtensions.cs

View workflow job for this annotation

GitHub Actions / build-windows (FAKE_XRM_EASY_2013)

The variable 'hasAggregates' is assigned but its value is never used

Check warning on line 76 in src/FakeXrmEasy.Core/Query/QueryExpressionExtensions.cs

View workflow job for this annotation

GitHub Actions / build-windows (FAKE_XRM_EASY)

The variable 'hasAggregates' is assigned but its value is never used

Check warning on line 76 in src/FakeXrmEasy.Core/Query/QueryExpressionExtensions.cs

View workflow job for this annotation

GitHub Actions / build-windows (FAKE_XRM_EASY)

The variable 'hasAggregates' is assigned but its value is never used

Check warning on line 76 in src/FakeXrmEasy.Core/Query/QueryExpressionExtensions.cs

View workflow job for this annotation

GitHub Actions / build-windows (FAKE_XRM_EASY_2015)

The variable 'hasAggregates' is assigned but its value is never used

Check warning on line 76 in src/FakeXrmEasy.Core/Query/QueryExpressionExtensions.cs

View workflow job for this annotation

GitHub Actions / build-windows (FAKE_XRM_EASY_2015)

The variable 'hasAggregates' is assigned but its value is never used

Check warning on line 76 in src/FakeXrmEasy.Core/Query/QueryExpressionExtensions.cs

View workflow job for this annotation

GitHub Actions / build-windows (FAKE_XRM_EASY_365)

The variable 'hasAggregates' is assigned but its value is never used

Check warning on line 76 in src/FakeXrmEasy.Core/Query/QueryExpressionExtensions.cs

View workflow job for this annotation

GitHub Actions / build-windows (FAKE_XRM_EASY_365)

The variable 'hasAggregates' is assigned but its value is never used

Check warning on line 76 in src/FakeXrmEasy.Core/Query/QueryExpressionExtensions.cs

View workflow job for this annotation

GitHub Actions / build-windows (FAKE_XRM_EASY_365)

The variable 'hasAggregates' is assigned but its value is never used

#if !FAKE_XRM_EASY
ValidateAliases(qe, context as XrmFakedContext);
#endif
#if FAKE_XRM_EASY_9
var aggregateExpressions = GetAggregateAttributeExpressions(qe);
hasAggregates = aggregateExpressions.Count > 0;
hasAggregates = aggregateExpressions?.Count > 0;
ValidateAggregates(qe, aggregateExpressions);
#endif

Expand Down Expand Up @@ -147,7 +147,7 @@
#if FAKE_XRM_EASY_9
private static List<XrmAttributeExpression> GetAggregateAttributeExpressions(QueryExpression qe)
{
return qe.ColumnSet
return qe.ColumnSet?
.AttributeExpressions
.Where(ae => ae.AggregateType != XrmAggregateType.None)
.ToList();
Expand Down Expand Up @@ -197,6 +197,11 @@

private static void ValidateAggregates(QueryExpression qe, List<XrmAttributeExpression> attributeExpressions)
{
if (qe.ColumnSet == null)
{
return;
}

var hasAggregateAttributeExpressions =
attributeExpressions.Count > 0;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,35 @@ public void TopCount_is_respected_for_query_by_attribute()
Assert.Equal(5, results.Entities.Count);
}

[Fact]
public void Should_execute_a_query_without_a_specific_column_set()
{
var contact1 = new Contact
{
Id = Guid.NewGuid(),
LastName = "asdf"
};

var contact2 = new Contact
{
Id = Guid.NewGuid(),
LastName = "qwer"
};

_context.Initialize(new List<Entity> { contact1, contact2 });

QueryByAttribute query = new QueryByAttribute("contact");
query.PageInfo = new PagingInfo()
{
PageNumber = 1,
Count = 1,
ReturnTotalRecordCount = true
};
var results = _service.RetrieveMultiple(query);

Assert.Single(results.Entities);
Assert.Equal(2, results.TotalRecordCount);
}

}
}
Loading