Robot Agnostic Foxglove by maxwellmlin · Pull Request #108 · DukeRobotics/robosub-ros2

maxwellmlin · 2025-12-05T02:20:34Z

Add automatic deployment of Foxglove extensions upon pushes to main.

Created new production environment with FOXGLOVE_API_KEY.

Add robot agnostic support to

System Status Panel
Discrete Servos Panel

System Status Panel

Copy topic on click
Error row on topic timeout (Closes System Status Panel #28)

Call Service Panel

Deprecate

Subscribe Topic Panel

Deprecate

Add buttons to automatically set ROBOT_NAME if it is not set.

Copilot

Pull request overview

This PR adds robot-agnostic support to the System Status Panel and Discrete Servos Panel, enabling these panels to adapt their display based on the selected robot (Crush or Oogway). It also deprecates the Call Service Panel and Subscribe Topic Panel by removing them entirely from the codebase.

Key changes:

Refactored System Status Panel to support robot-specific configurations with topic timeout detection and click-to-copy functionality
Updated Discrete Servos Panel to display robot-specific servo controls
Removed Call Service Panel and Subscribe Topic Panel extensions
Updated documentation to reflect deprecated panels

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
foxglove/extensions/system-status-panel/src/SystemStatusPanel.tsx	Refactored to support robot-agnostic configuration, added topic timeout detection, click-to-copy functionality, and robot name validation
foxglove/extensions/discrete-servos-panel/src/DiscreteServosPanel.tsx	Added robot-agnostic support with robot-specific servo configurations
foxglove/extensions/sensors-status-panel/src/SensorsStatusPanel.tsx	Reordered Tooltip and TableRow components for consistency
foxglove/extensions/subscribe-topic-panel/*	Removed all files to deprecate the panel
foxglove/extensions/call-service-panel/*	Removed all files to deprecate the panel
foxglove/extensions/publish-topic-panel/README.md	Enhanced documentation with feature list and use cases
foxglove/README.md	Updated extensions list to remove deprecated panels

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 21 out of 21 changed files in this pull request and generated 5 comments.

Comments suppressed due to low confidence (1)

foxglove/extensions/discrete-servos-panel/src/DiscreteServosPanel.tsx:27

The type name DiscreteServosPanel conflicts with the function name DiscreteServosPanel. Consider renaming the type to DiscreteServosPanelState to match the naming pattern used elsewhere and avoid confusion.

type DiscreteServosPanel = {
  message?: string; // Response from service call
  success?: boolean; // Whether the service call was successful
};

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

nathanaelren · 2025-12-07T18:38:46Z

@maxwellmlin What is the alternative to the call service panel? Is the goal to have dedicated panels for all services we might want to call (i.e., servos)?

maxwellmlin · 2025-12-07T18:55:04Z

@maxwellmlin What is the alternative to the call service panel? Is the goal to have dedicated panels for all services we might want to call (i.e., servos)?

@nathanaelren Foxglove already has the Service Call and Raw Messages panel which does the same thing as our Call Service Panel and Subscribe Topic Panel. This confuses new members so I think we should remove them. (Although Foxglove has a Publish panel, our Publish Topic Panel is better so we're keeping that one.)

nathanaelren · 2025-12-07T19:30:12Z

@maxwellmlin What is the alternative to the call service panel? Is the goal to have dedicated panels for all services we might want to call (i.e., servos)?

@nathanaelren Foxglove already has the Service Call and Raw Messages panel which does the same thing as our Call Service Panel and Subscribe Topic Panel. This confuses new members so I think we should remove them. (Although Foxglove has a Publish panel, our Publish Topic Panel is better so we're keeping that one.)

@maxwellmlin Got it, thanks. Agree on our publish topic panel. I think the readme about service calling was good though, do you think it's reasonable to add a separate readme on how to do the service call?

maxwellmlin · 2025-12-07T19:43:55Z

@maxwellmlin What is the alternative to the call service panel? Is the goal to have dedicated panels for all services we might want to call (i.e., servos)?

@nathanaelren Foxglove already has the Service Call and Raw Messages panel which does the same thing as our Call Service Panel and Subscribe Topic Panel. This confuses new members so I think we should remove them. (Although Foxglove has a Publish panel, our Publish Topic Panel is better so we're keeping that one.)

@maxwellmlin Got it, thanks. Agree on our publish topic panel. I think the readme about service calling was good though, do you think it's reasonable to add a separate readme on how to do the service call?

@nathanaelren I think it's OK to omit. The Foxglove Service Call panel pre-populates the request JSON so I don't think we need an example anymore.

nathanaelren

Looks good to me!

nathanaelren · 2025-12-07T23:18:12Z

@maxwellmlin What is the alternative to the call service panel? Is the goal to have dedicated panels for all services we might want to call (i.e., servos)?

@nathanaelren Foxglove already has the Service Call and Raw Messages panel which does the same thing as our Call Service Panel and Subscribe Topic Panel. This confuses new members so I think we should remove them. (Although Foxglove has a Publish panel, our Publish Topic Panel is better so we're keeping that one.)

@maxwellmlin Got it, thanks. Agree on our publish topic panel. I think the readme about service calling was good though, do you think it's reasonable to add a separate readme on how to do the service call?

@nathanaelren I think it's OK to omit. The Foxglove Service Call panel pre-populates the request JSON so I don't think we need an example anymore.

Sounds good, thanks. Seems reasonable to me, we can merge in

* Robot Agnostic Foxglove (#108) * Robot agnostic support * Robot agnostic support * Add status timeout * Copy topic on click * Deprecate call-service-panel and subscribe-topic-panel * Update foxglove/extensions/system-status-panel/src/SystemStatusPanel.tsx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Add buttons to set ROBOT_NAME * Add toasts for copy action * Disable buttons when callService unavailable * Initial attempt at automatic deployement * Add test branch * Remove variable check * Only publish on pushes to main * Rename * Update docs * Update docs * Delete sonar_plot.png (#110) * WIP new HSV Refactoring * Skeleton hsv_lane_marker.py code * Address Max's comments * Added additional publishers * Updated countor processing * Clean up code for hsv_lane_marker's process_contours * Updated publishers in the process contour method * Update launch -- kept the info for launching lane_marker_detector.py but got rid of it from setup.py * Removed double quotes * Move hsv scripts into hsv_filters * Adjusted setup.py to reflect new structure of the cv package * Linted --------- Co-authored-by: Maxwell Lin <git@maxwellmlin.com> Co-authored-by: Viet Hung Le <brandon.viethungRI2001@gmail.com> Co-authored-by: Pranav Bijith <pranavbijith1@gmail.com>

maxwellmlin added 5 commits December 4, 2025 19:25

Robot agnostic support

b9df17a

Robot agnostic support

abb1427

Add status timeout

92b686c

Copy topic on click

c4dd43f

Deprecate call-service-panel and subscribe-topic-panel

2130fa5

maxwellmlin requested a review from nathanaelren December 5, 2025 02:53

maxwellmlin self-assigned this Dec 5, 2025

maxwellmlin requested a review from Copilot December 5, 2025 02:57

Copilot started reviewing on behalf of maxwellmlin December 5, 2025 02:58 View session

maxwellmlin changed the title ~~Robot agnostic foxglove~~ Robot Agnostic Foxglove Dec 5, 2025

Copilot finished reviewing on behalf of maxwellmlin December 5, 2025 02:59

Copilot AI reviewed Dec 5, 2025

View reviewed changes

Comment thread foxglove/extensions/system-status-panel/src/SystemStatusPanel.tsx Outdated

Comment thread foxglove/extensions/discrete-servos-panel/src/DiscreteServosPanel.tsx

maxwellmlin and others added 2 commits December 4, 2025 22:03

Update foxglove/extensions/system-status-panel/src/SystemStatusPanel.tsx

14c6e46

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Merge branch 'main' into robot-agnostic-foxglove

7f9b07b

maxwellmlin marked this pull request as ready for review December 5, 2025 03:03

Add buttons to set ROBOT_NAME

a6ccc65

maxwellmlin requested a review from Copilot December 5, 2025 16:54

Copilot started reviewing on behalf of maxwellmlin December 5, 2025 16:55 View session

Copilot finished reviewing on behalf of maxwellmlin December 5, 2025 16:59

Copilot AI reviewed Dec 5, 2025

View reviewed changes

maxwellmlin added 4 commits December 6, 2025 00:50

Add toasts for copy action

cf5c18d

Disable buttons when callService unavailable

2679b30

Initial attempt at automatic deployement

a3413a3

Add test branch

3798fd8

maxwellmlin temporarily deployed to production December 6, 2025 01:44 — with GitHub Actions Inactive

Remove variable check

5dbf115

maxwellmlin temporarily deployed to production December 6, 2025 01:54 — with GitHub Actions Inactive

Only publish on pushes to main

26d83b6

maxwellmlin requested a review from Copilot December 6, 2025 02:07

Copilot started reviewing on behalf of maxwellmlin December 6, 2025 02:07 View session

Copilot AI reviewed Dec 6, 2025

View reviewed changes

maxwellmlin added 3 commits December 6, 2025 02:16

Rename

66bc27d

Update docs

fee8c44

Update docs

1ff23f1

nathanaelren approved these changes Dec 7, 2025

View reviewed changes

maxwellmlin merged commit a74efff into main Dec 8, 2025
1 check passed

maxwellmlin deleted the robot-agnostic-foxglove branch December 8, 2025 00:01

Conversation

maxwellmlin commented Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nathanaelren commented Dec 7, 2025

Uh oh!

maxwellmlin commented Dec 7, 2025

Uh oh!

nathanaelren commented Dec 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maxwellmlin commented Dec 7, 2025

Uh oh!

nathanaelren left a comment

Choose a reason for hiding this comment

Uh oh!

nathanaelren commented Dec 7, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

maxwellmlin commented Dec 5, 2025 •

edited

Loading

nathanaelren commented Dec 7, 2025 •

edited

Loading