Enhance payment form submission by disabling empty fields#37915
Open
AW-95 wants to merge 16 commits intoDolibarr:developfrom
Open
Enhance payment form submission by disabling empty fields#37915AW-95 wants to merge 16 commits intoDolibarr:developfrom
AW-95 wants to merge 16 commits intoDolibarr:developfrom
Conversation
|
@eldy done please check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FIX|Fix submission of empty payment amounts in payment form
When submitting the payment form, all input fields (including empty invoice amounts) are sent to the server.
This can lead to unnecessary or incorrect processing of empty values, especially in cases with multiple invoices or multicurrency fields.
This patch ensures that:
As a result, only relevant (non-empty) invoice payment amounts are submitted.
Technical details
A jQuery handler is added on form submission to disable unnecessary inputs:
Before
All fields were submitted, including empty ones.
After
Only non-empty amount fields are submitted.