fix(backups): prevent S3 credentials from being exposed in logs#4631
Open
zexxitywave wants to merge 1 commit into
Open
fix(backups): prevent S3 credentials from being exposed in logs#4631zexxitywave wants to merge 1 commit into
zexxitywave wants to merge 1 commit into
Conversation
dosubot
Bot
added
size:M
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR about?
This PR fixes an issue where S3 backup credentials could be exposed through backup logging.
The backup flow was logging
rcloneCommand, which contains S3 access keys and secret access keys passed as command-line flags. This change removes credential-bearing command data from logger output and sanitizes backup-related error logging to reduce the risk of secrets being written to service stdout.Checklist
canaryIssues related
Fixes #4621