fix: validate API key prefixes before creation#4629
Open
KirillYarkov wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
better-auth.undefined.Root Cause
user.createApiKeyaccepted anyprefixstring and passed it through tobetter-auth. Invalid prefixes were rejected there as a generic error, which surfaced through tRPC asINTERNAL_SERVER_ERROR/ HTTP 500 instead of a client validation error. The UI also discarded server error details and always showedFailed to generate API key.Validation
npx --yes pnpm@10.22.0 --dir apps/dokploy exec vitest --config __test__/vitest.config.ts __test__/user/create-api-key-errors.test.ts __test__/user/create-api-key.test.ts --runnpx --yes pnpm@10.22.0 exec biome check apps/dokploy/__test__/user/create-api-key-errors.test.ts apps/dokploy/__test__/user/create-api-key.test.ts apps/dokploy/components/dashboard/settings/api/api-key-errors.ts apps/dokploy/components/dashboard/settings/api/add-api-key.tsx apps/dokploy/server/api/routers/user.ts packages/server/src/services/user.tsnpx --yes pnpm@10.22.0 --filter=dokploy typechecknpx --yes pnpm@10.22.0 --filter=@dokploy/server typecheckNote: local checks ran under Node v18.19.1, while
.nvmrcspecifies Node 24.4.0, so pnpm emitted engine warnings.