fix: allow resetting volume backup retention to unlimited#4588
Open
ravindu0823 wants to merge 1 commit into
Open
fix: allow resetting volume backup retention to unlimited#4588ravindu0823 wants to merge 1 commit into
ravindu0823 wants to merge 1 commit into
Conversation
Clearing the "Keep Latest Backups" field on a volume backup did not persist: the form computed `null` for an empty input but then collapsed it back to `undefined` (`preparedKeepLatestCount ?? undefined`) before sending it. The update uses drizzle's `.set()`, which silently omits `undefined` keys, so the previous limit was left untouched and could never be turned off again. Extract the decision into a pure `prepareKeepLatestCount` helper that returns `null` (unlimited) for an empty/whitespace input and the numeric value otherwise, and send that value directly so the column is written. Fixes Dokploy#4184 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
dosubot
Bot
added
the
size:S
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@-