Migrate to github actions#37
Merged
Christian Cadruvi (ccadruvi) merged 2 commits intomainfrom Apr 29, 2025
Merged
Conversation
Christian Cadruvi (ccadruvi)
temporarily deployed
to
Production
GitHub Actions
Inactive
There was a problem hiding this comment.
Pull Request Overview
This pull request migrates the build-docker workflow to use GitHub settings and an external reusable workflow from a public repository.
- Updates branch triggers from a wildcard to "main"
- Adds new GitHub token permissions for pull requests and issues
- Switches the reusable workflow reference to an external public action and updates corresponding parameters
Files not reviewed (5)
- .github/workflows/action.yml: Language not supported
- .github/workflows/reusable-docker-build-and-push.yml: Language not supported
- azure-pipelines.yml: Language not supported
- build/docker-bake.hcl: Language not supported
- netboot-services/tftp/Dockerfile: Language not supported
Comments suppressed due to low confidence (2)
.github/workflows/build-docker.yaml:6
- The branch trigger has been changed from a wildcard to 'main'. Confirm this change aligns with the intended deployment strategy.
- "main"
.github/workflows/build-docker.yaml:18
- Ensure that the external reusable workflow and removed secret 'azure_managed_identity_clientid' are intentional changes that do not disrupt the Docker image build process.
uses: DigitecGalaxus/public-actions/.github/workflows/reusable-docker-build-and-push.yml@master
Contributor
Mazlum Toprak (mazlumtoprak)
left a comment
Mazlum Toprak (mazlumtoprak)
left a comment
There was a problem hiding this comment.
lgtm. Do you want to quickly come over and discuss the docker-bake stuff?
Mazlum Toprak (mazlumtoprak)
approved these changes
Apr 29, 2025
Christian Cadruvi (ccadruvi)
deleted the
feature/planetepxress/psa-34799-migrate-to-github
branch
Christian Cadruvi (ccadruvi)
added a commit
that referenced
this pull request
Jun 30, 2025
This reverts commit 963c743.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.