Skip to content

Conversation

@jacob720
Copy link
Contributor

@jacob720 jacob720 commented Jan 8, 2026

Fixes #1474

Instructions to reviewer on how to test:

  1. Check tests pass
  2. Check tox tools still work
  3. Check uv works as intended

Checks for reviewer

  • Would the PR title make sense to a user on a set of release notes

@jacob720 jacob720 requested a review from a team as a code owner January 8, 2026 14:15
@jacob720 jacob720 added the dev experience Changes relating to developer experience label Jan 8, 2026
@codecov
Copy link

codecov bot commented Jan 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.65%. Comparing base (75ea250) to head (1b21512).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1536      +/-   ##
==========================================
- Coverage   92.67%   92.65%   -0.02%     
==========================================
  Files         152      151       -1     
  Lines        8464     8433      -31     
==========================================
- Hits         7844     7814      -30     
+ Misses        620      619       -1     
Components Coverage Δ
i24 SSX 78.56% <ø> (ø)
hyperion 98.11% <ø> (ø)
other 98.27% <ø> (+0.01%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jacob720 jacob720 marked this pull request as draft January 8, 2026 15:42
@jacob720 jacob720 force-pushed the 1474_update_copier_template branch from 6073361 to e8840db Compare January 8, 2026 16:07
@jacob720 jacob720 force-pushed the 1474_update_copier_template branch from e8840db to cfe3772 Compare January 8, 2026 16:23
@jacob720 jacob720 marked this pull request as ready for review January 9, 2026 14:37
@rtuck99 rtuck99 self-assigned this Jan 9, 2026
pyproject.toml Outdated
[
"pyright",
"--pythonpath",
".venv/bin/python",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see dodal PR comment re venv location

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done the same thing you did on Dodal

.. code-block:: bash

pip install pytest-profiling
uv add pytest-profiling
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to uv add this, probably just uv pip install


cd prof
pip install snakeviz
uv add --frozen snakeviz
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@@ -16,33 +16,37 @@ if [ "$current_dir" != "$two_levels_up" ]; then
exit 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are also some changes needed in deploy_mx_bluesky_app_to_k8s.sh

@@ -1,26 +1,34 @@
# The devcontainer should use the developer target and run as root with podman
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, now that blueapi is now on uv, that Dockerfile.blueapi might need to be updated.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto Dockerfile.hyperion

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The containers seem to build fine, I think when we update which blueapi image we pull we'll have to change the Dockerfile but might be worth doing this in a separate PR?

Copy link
Contributor Author

@jacob720 jacob720 Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to update Dockerfile.hyperion to use uv but kept getting errors about device space when building locally, I think this may be because uv caches more than pip?
I think we should do Dockerfile.blueapi seperately as pulling the new blueapi image will break stuff #1516

@jacob720 jacob720 requested a review from rtuck99 January 16, 2026 14:42
Copy link
Contributor

@rtuck99 rtuck99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, need to update to get tests to pass against latest dodal,

@jacob720 jacob720 enabled auto-merge (squash) January 19, 2026 11:55
@DominicOram
Copy link
Contributor

Some thoughts as discussed:

  • The CI is failing because we haven't run uv sync after DiamondLightSource/dodal@905cd1f was merged into main. Once this is merged uv sync will be in the pre-commit hook so won't be an issue. We can fix this manually on here and see how it goes. We may want to get a uv sync in the CI at some point in the future though
  • It would be good for the CI to print the versions of things that we're running in the CI as it used to do this.
  • @jacob720 and I had some discussion about the value of having the lock file in git, I think we may want to remove it at some point but we can just run with it and see

@jacob720 jacob720 merged commit 039028b into main Jan 19, 2026
9 of 10 checks passed
@jacob720 jacob720 deleted the 1474_update_copier_template branch January 19, 2026 14:00
jacob720 added a commit that referenced this pull request Jan 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev experience Changes relating to developer experience

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update copier to pre-release

4 participants