-
Notifications
You must be signed in to change notification settings - Fork 4
Update copier template #1536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update copier template #1536
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1536 +/- ##
==========================================
- Coverage 92.67% 92.65% -0.02%
==========================================
Files 152 151 -1
Lines 8464 8433 -31
==========================================
- Hits 7844 7814 -30
+ Misses 620 619 -1
🚀 New features to boost your workflow:
|
6073361 to
e8840db
Compare
e8840db to
cfe3772
Compare
pyproject.toml
Outdated
| [ | ||
| "pyright", | ||
| "--pythonpath", | ||
| ".venv/bin/python", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see dodal PR comment re venv location
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done the same thing you did on Dodal
| .. code-block:: bash | ||
|
|
||
| pip install pytest-profiling | ||
| uv add pytest-profiling |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't want to uv add this, probably just uv pip install
|
|
||
| cd prof | ||
| pip install snakeviz | ||
| uv add --frozen snakeviz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
utility_scripts/dls_dev_env.sh
Outdated
| @@ -16,33 +16,37 @@ if [ "$current_dir" != "$two_levels_up" ]; then | |||
| exit 1 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there are also some changes needed in deploy_mx_bluesky_app_to_k8s.sh
| @@ -1,26 +1,34 @@ | |||
| # The devcontainer should use the developer target and run as root with podman | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, now that blueapi is now on uv, that Dockerfile.blueapi might need to be updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto Dockerfile.hyperion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The containers seem to build fine, I think when we update which blueapi image we pull we'll have to change the Dockerfile but might be worth doing this in a separate PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to update Dockerfile.hyperion to use uv but kept getting errors about device space when building locally, I think this may be because uv caches more than pip?
I think we should do Dockerfile.blueapi seperately as pulling the new blueapi image will break stuff #1516
rtuck99
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, need to update to get tests to pass against latest dodal,
|
Some thoughts as discussed:
|
Fixes #1474
Instructions to reviewer on how to test:
Checks for reviewer