-
Notifications
You must be signed in to change notification settings - Fork 4
Use daq config server for UndulatorDCM config #1497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
c4613e8 to
7c21294
Compare
7c21294 to
0ec62f4
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1497 +/- ##
=======================================
Coverage 92.32% 92.32%
=======================================
Files 143 143
Lines 8126 8131 +5
=======================================
+ Hits 7502 7507 +5
Misses 624 624
🚀 New features to boost your workflow:
|
rtuck99
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me, however would be nice to see some minimal system tests with the config server so that we can verify we can read configs. I think also that having such tests also does help with thinking about endpoint configuration.
Fixes #1494
Link to dodal PR (if required): DiamondLightSource/dodal#1768
Reads
UndulatorDCMconfig through the config server.Instructions to reviewer on how to test:
Checks for reviewer