Skip to content

Conversation

@rtuck99
Copy link
Contributor

@rtuck99 rtuck99 commented Dec 1, 2025

Fixes #1426

Post 9.33+, GDA no longer has many variables in its environment and these are not exported to the run_hyperion.sh script when it is spawned. Therefore the script no longer has access to the module command and consequently ZOCALO_CONFIG is never defined because dials is never loaded.

Instructions to reviewer on how to test:

  1. Hyperion can still start with latest GDA master
  2. Hyperion can still start with previous GDA master

Checks for reviewer

  • Would the PR title make sense to a user on a set of release notes

@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.72%. Comparing base (8b545a6) to head (45eb45c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1490   +/-   ##
=======================================
  Coverage   92.72%   92.72%           
=======================================
  Files         152      152           
  Lines        8499     8499           
=======================================
  Hits         7881     7881           
  Misses        618      618           
Components Coverage Δ
i24 SSX 78.56% <ø> (ø)
hyperion 98.20% <ø> (ø)
other 98.27% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rtuck99 rtuck99 added the hyperion Issues for Hyperion, the Bluesky UDC stack label Dec 4, 2025
@rtuck99 rtuck99 marked this pull request as ready for review December 4, 2025 13:30
@rtuck99 rtuck99 requested a review from a team as a code owner December 4, 2025 13:30
@rtuck99 rtuck99 force-pushed the 1426_changes_for_post_gda_9_33 branch from 6306ba8 to fa17520 Compare December 9, 2025 09:04
@rtuck99 rtuck99 force-pushed the 1426_changes_for_post_gda_9_33 branch from fa17520 to 45eb45c Compare January 26, 2026 15:42
Copy link
Contributor

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks fine, thanks.

Fixes #1426

Does this mean that the beamline is currently using GDA master for everything? If not then we should probably either keep the original issue open until it is or make a new issue that is to make sure they've switched

@rtuck99
Copy link
Contributor Author

rtuck99 commented Jan 26, 2026

Change looks fine, thanks.

Fixes #1426

Does this mean that the beamline is currently using GDA master for everything? If not then we should probably either keep the original issue open until it is or make a new issue that is to make sure they've switched

They are still on "old master", however I went through the other gerrit changes in the ticket today and they are now all merged, so I believe this is the only thing preventing them moving up.

@rtuck99 rtuck99 merged commit 89bfb4b into main Jan 26, 2026
17 checks passed
@rtuck99 rtuck99 deleted the 1426_changes_for_post_gda_9_33 branch January 26, 2026 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hyperion Issues for Hyperion, the Bluesky UDC stack

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update GDA on i03 and run Hyperion only in UDC

3 participants