Defer release publication until publish#392
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR changes the release pipeline so that building artifacts still happens on tag pushes, but publishing (PyPI + versioned docs deployment) is deferred until the corresponding GitHub Release is published.
Changes:
- Added a dedicated
release-triggered workflow to publish to PyPI only when a release is published (and tag starts withv). - Removed the tag-push-driven PyPI publish job from the main CI workflow.
- Updated the docs Pages workflow to deploy versioned docs on
release.published(and restrict artifact-based deploys to successfulmainpushes).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/release-publish.yml |
New workflow that builds from the published tag and publishes to PyPI via Trusted Publishing. |
.github/workflows/main.yml |
Removes the previous tag-push PyPI publishing job while keeping tag builds/artifacts. |
.github/workflows/docs-pages.yml |
Adds release.published as a deployment trigger and tightens artifact deploy conditions to main pushes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+22
to
+25
| - uses: actions/checkout@v4 | ||
| with: | ||
| ref: ${{ github.event.release.tag_name }} | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR prevents a GitHub release draft tag from publishing EmbodiChain distributions to PyPI or deploying versioned documentation.
Tag pushes continue to build CI artifacts. PyPI publication and release-doc deployment now run only when the associated GitHub release is published.
Dependencies: None.
Type of change
Screenshots
Not applicable.
Checklist