Skip to content

fix: Move byte-buddy to testImplementation scope#282

Merged
satsukies merged 2 commits into
masterfrom
fix/byte-buddy-test-scope
Jun 3, 2026
Merged

fix: Move byte-buddy to testImplementation scope#282
satsukies merged 2 commits into
masterfrom
fix/byte-buddy-test-scope

Conversation

@satsukies
Copy link
Copy Markdown
Member

Closes #281

Summary

net.bytebuddy:byte-buddy was declared with implementation scope, but it is only needed by Spock for mocking concrete classes at test time (it is never referenced under src/). This incorrect scope put byte-buddy on the plugin runtime classpath, so Gradle TestKit injected and repackaged it during acceptance tests — and dependabot's bump to 1.18.9 broke that repackaging on older Gradle (≤ 8.2), failing all acceptance tests with Failed to create Jar file byte-buddy-1.18.9.jar.

See #281 for the full root-cause analysis and history.

Changes

Verification

  • Confirmed byte-buddy no longer appears in createClasspathManifest / sourceSets.main.runtimeClasspath (the TestKit-injected plugin classpath), so the jar-repackaging failure can no longer occur on any Gradle version.
  • Confirmed byte-buddy is removed from runtimeClasspath but retained on testRuntimeClasspath (Spock concrete-class mocking preserved).
  • The remaining acceptance-test verification (older Gradle versions) is delegated to CI.

🤖 Generated with Claude Code

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the net.bytebuddy:byte-buddy dependency in build.gradle from version 1.15.11 to 1.18.9 and changes its configuration from implementation to testImplementation. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@satsukies satsukies self-assigned this Jun 3, 2026
@satsukies satsukies marked this pull request as ready for review June 3, 2026 03:07
Copilot AI review requested due to automatic review settings June 3, 2026 03:07
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@satsukies satsukies requested a review from tnj June 3, 2026 03:08
Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

Copy link
Copy Markdown
Member

@tnj tnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@satsukies
Copy link
Copy Markdown
Member Author

thanks!

@satsukies satsukies merged commit 30ccd9e into master Jun 3, 2026
23 checks passed
@satsukies satsukies deleted the fix/byte-buddy-test-scope branch June 3, 2026 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Breaking TestKit acceptance tests on older Gradle versions caused by inconsistent scope

3 participants