Skip to content

docs(github-pr-workflow): add rule to not block sessions waiting on CI #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dembrane-sam-bot wants to merge 3 commits into
base: main
Choose a base branch
from
Open

docs(github-pr-workflow): add rule to not block sessions waiting on CI #89

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
374faf0
docs(github-pr-workflow): add rule to not block sessions waiting on CI
dembrane-sam-bot May 26, 2026
5d8730e
Merge branch 'main' into sam/docs-no-block-on-ci
spashii May 26, 2026
a7d68ab
Merge branch 'main' into sam/docs-no-block-on-ci
spashii May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/skills/github-pr-workflow/skill.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,9 +135,13 @@ This section earns trust over time. Hide problems in it once and it becomes usel

Post in Slack with the PR link and a one-line *consequence* summary — what the merge will change for the team, and what (if anything) is shaky enough to watch after it lands. Not "opened a PR titled X"; rather "PR up to fix the export timezone bug — safe for the next migration window, flagging the rollback path as untested." See `src/identity.md` "Lead with the consequence" for the framing.

Watch CI. When CI completes:
Watch CI. If CI is going to take more than ~60 seconds to complete, **do not sit in sleep loops waiting for it** (as seen in session `e0c352b08e45` which accumulated 11× `sleep` and timed out on 2026-05-25).

- **Green:** post in Slack. PR stays draft pending review.
Instead, post the PR link with the current CI status, exit the session cleanly, and let a subsequent session or daemon poll catch up on the result once CI completes.

When CI does complete and you are back in a session:

- **Green:** post in Slack. PR stays draft pending review (unless the PR was opened on a self-maintenance branch, in which case auto-merge was already enabled at PR creation).
- **Red:** read the logs and decide. If the failure is clearly Sam's, fix and push. If it looks like flake or infra, say so in Slack and ask whether to retry. If unsure, post what Sam sees and ask.

Don't push fixes blindly. Each push should have a reason Sam can name.
Expand Down
Loading