Skip to content

fix(frontend): align layout elements and refine breadcrumbs based on page feedback #600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dembrane-sam-bot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(frontend): align layout elements and refine breadcrumbs based on page feedback #600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion echo/frontend/src/components/layout/PageContainer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ export const PageContainer = ({
const pyClass = density === "tight" ? "py-6" : "py-10";
return (
<div
className={`mx-auto w-full px-6 md:px-10 ${pyClass} ${className ?? ""}`}
className={`mr-auto w-full px-6 md:px-10 ${pyClass} ${className ?? ""}`}
style={{ maxWidth, ...style }}
>
{children}
Expand Down
4 changes: 2 additions & 2 deletions echo/frontend/src/components/project/ProjectQRCode.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,10 +128,10 @@ export const ProjectQRCode = ({ project }: ProjectQRCodeProps) => {
return (
<Paper
p="md"
className="relative flex h-full flex-col items-center justify-center"
className="relative flex h-full flex-col items-start justify-center"
>
{project?.is_conversation_allowed ? (
<Group align="center" justify="center" gap="lg">
<Group align="center" justify="start" gap="lg">
<QRCode
value={link}
href={link}
Expand Down
13 changes: 4 additions & 9 deletions echo/frontend/src/features/sidebar/breadcrumbs/AppBreadcrumbs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,14 +142,9 @@ export const AppBreadcrumbs = () => {
href: `/w/${workspace.id}/home`,
label: workspace.name,
});
const section = params.section;
if (window.location.pathname.endsWith("/projects/new")) {
out.push({ label: "New project" });
} else if (section === "home" || !section) {
out.push({ label: "Overview" });
} else {
out.push({ label: "Overview" });
}
if (window.location.pathname.endsWith("/projects/new")) {
out.push({ label: "New project" });
}
return out;
}
case "workspace-settings": {
Expand Down Expand Up @@ -180,7 +175,7 @@ export const AppBreadcrumbs = () => {
});
}
const section = params.section;
if (section && PROJECT_SECTION_LABELS[section]) {
if (section && section !== "home" && PROJECT_SECTION_LABELS[section]) {
out.push({ label: PROJECT_SECTION_LABELS[section] });
}
return out;
Expand Down
2 changes: 0 additions & 2 deletions echo/frontend/src/routes/project/ProjectHomeRoute.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,6 @@ export const ProjectHomeRoute = () => {
<Group gap="sm" wrap="wrap">
<Button
leftSection={<ChatCircleDots size={16} />}
variant="filled"
color="blue"
onClick={() => navigate(`${base}/chats/new`)}
>
<Trans>Start a chat</Trans>
Expand Down
Loading