Skip to content

fix(frontend): persist sidebar on host guide page and toggle fullscreen layout #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dembrane-sam-bot merged 4 commits into from
Jun 2, 2026
Merged

fix(frontend): persist sidebar on host guide page and toggle fullscreen layout #599

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a3869f6
fix(frontend): persist sidebar on host guide page and toggle fullscre…
dembrane-sam-bot May 27, 2026
b2f3bcb
Merge branch 'main' into sam/host-guide-sidebar-persistence
ussaama Jun 2, 2026
2e76819
Merge branch 'main' into sam/host-guide-sidebar-persistence
ussaama Jun 2, 2026
c03c0b3
fix(frontend): stretch host guide toolbar full-width when not fullscreen
dembrane-sam-bot Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions echo/frontend/src/Router.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,16 +416,16 @@ export const mainRouter = createBrowserRouter([
element: <Navigate to="home" replace />,
index: true,
},
{
element: <HostGuidePage />,
path: "projects/:projectId/host-guide",
},
{
children: [
{
element: <ProjectsHomeRoute />,
path: "home",
},
{
element: <HostGuidePage />,
path: "projects/:projectId/host-guide",
},
{
// Splat so the tab lives in the path
// (/w/:workspaceId/settings/:tab). The component parses
Expand Down
9 changes: 8 additions & 1 deletion echo/frontend/src/routes/project/HostGuidePage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1387,6 +1387,13 @@ export const HostGuidePage = () => {
padding: space.page,
paddingTop: isFullscreen ? space.page : `calc(${space.page} + 48px)`,
transition: "padding-top 0.2s",
position: isFullscreen ? "fixed" : "relative",
top: isFullscreen ? 0 : undefined,
left: isFullscreen ? 0 : undefined,
width: isFullscreen ? "100vw" : "100%",
height: isFullscreen ? "100vh" : undefined,
zIndex: isFullscreen ? 1000 : undefined,
overflowY: isFullscreen ? "auto" : undefined,
}}
>
{/* Fullscreen exit zone — thin invisible strip at top edge */}
Expand All @@ -1410,7 +1417,7 @@ export const HostGuidePage = () => {
className="no-print"
style={{
left: 0,
position: "fixed",
position: isFullscreen ? "fixed" : "absolute",
right: 0,
top: 0,
transform: isFullscreen ? "translateY(-100%)" : "translateY(0)",
Expand Down
Loading