ci(publish-maven): save NVD cache on timeout too + allow cold sync to finish - #90
Merged
Merged
Conversation
… finish PR #89's fix restored the weekly NVD cache but the follow-up save step used !cancelled(), which also evaluates true when the job is cancelled by hitting timeout-minutes — exactly the case a throttled cold sync was expected to hit. Use always() so a timed-out cold sync still persists partial progress for the next attempt. Also raise timeout-minutes 90 -> 240: a real cold sync (first run ever, no prior cache) downloads ~373k NVD records at NVD's observed throttle rate of ~2k/min, i.e. ~190min before build/sign/deploy even starts. Confirmed via run 30885793947 for the 1.6.5 protobuf-schemas publish, which was cancelled by the 90min timeout at 46% (170k/372.9k records).
Deploying exchange-testnet with
|
| Latest commit: |
a7f2ddf
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ab8d9309.exchange-testnet.pages.dev |
| Branch Preview URL: | https://ci-nvd-save-on-cancel-and-lo.exchange-testnet.pages.dev |
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
!cancelled(), which is also true when the job is cancelled by hittingtimeout-minutes— exactly the scenario a throttled cold sync was expected to hit. Switched toalways()so a timed-out cold sync still persists partial progress for the next attempt.timeout-minutes90 -> 240: a genuine cold sync (first run ever, no prior cache) downloads ~373k NVD CVE records at NVD's observed throttle rate of ~2k records/min, i.e. ~190min before build/sign/deploy even starts. Subsequent weekly-incremental runs are expected to finish in a few minutes once a cache exists.Evidence
Run 30885793947 (1.6.5 protobuf-schemas publish dispatch) was cancelled by the 90min timeout at 46% (170,000/372,884 records synced), with no cache ever having been saved for
owasp-dependency-check-nvd-*(confirmed via the repo's actions cache list, which had zero matching entries before this run and still has zero after, since the timeout skipped the save step).Test plan
publish-protobuf-schemas.ymlfor 1.6.5 after merge and confirm the audit gate completes (cold sync) within the new 240min windowactions/cachelist shows a savedowasp-dependency-check-nvd-*entry afterward