Add src_eff, if provided, to ordering of latest sat records too#261
Add src_eff, if provided, to ordering of latest sat records too#261mrjovana wants to merge 1 commit into
Conversation
|
Hello, Thanks for this PR. We already added support for this as of AutomateDV 0.11.1, please upgrade to make use of this change :) |
|
hey @DVAlexHiggs , please check once again... I know you added already this clause to newly incoming source records, but I don't see it for latest records in existing target satellite (not in 0.11.1 or 0.11.2) - important to determine what is real latest-latest in existing sat, in case multiple changes were loaded within same load_dt previously. |
|
Ah I see, apologies for my misunderstanding! This does make sense, I will re-open the PR. Unfortunately we cannot accept PRs directly to this repo at the current time, and our development repo with our full test-suite is not public. If and when we implement this change, I will ensure you are credited in the release. Apologies for the inconvenience around how this works at this time. |
|
Not a problem at all, just please let me know if and when this change is implemented. Thank you very much @DVAlexHiggs |
Changes made to sat macro, in order to enable proper ordering during load of intra-day changes with same load_dt but different src_eff: