Address SOSO SHACL Feedback & Cleanup#78
Open
ThomasThelen wants to merge 7 commits intoDataONEorg:developfrom
Open
Address SOSO SHACL Feedback & Cleanup#78ThomasThelen wants to merge 7 commits intoDataONEorg:developfrom
ThomasThelen wants to merge 7 commits intoDataONEorg:developfrom
Conversation
…emove redland artifacts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few updates to Slinky for the 0.3.0 release
Slinky Dockerfile
/var/lib/apt/lists/(don't need it after package installs) citeVirtuoso
We had two copies of our custom Virtuoso Dockerfile. I removed the redundant one in the test directory
dump-virtuoso
The dump-virtuoso script is used to export all triples out of virtuoso. It requires that the
_dump_nquads_function be defined within Virtuoso (which default deployments no longer do). I added this function and another bit to copy the data files out of the container.Web
Addresses a few points in #73. Since the page depends on yasgui and the css, I left them as blocking resources.
Triple Pattern Changes
I ran the SOSO 1.2.3 SHACL file against the triples we're producing in develop with
These are the results. This PR currently fixes the keywords violation and sameAs warning.
schema:keywordfor describing keywords - but it should beschema:keywordsowl:sameAswhere SOSO wantsschema:sameAS. Adding both might not be a bad idea (but I went with only using schema)there was a second violation with schema:version - but I filed an issue for that one.
Google Recommended
We fail a few of the recommended google shapes (we pass the required one though).
For 0.3.0 these might not be worth addressing and could go in a 0.3.1.