[Backport v0.11] Add dry_run label to all WPA Prometheus metrics#341
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intov0.11from Apr 9, 2026
Merged
Conversation
The value GaugeVec now includes dryRunPromLabel in its label list via defaultPromLabels. The three Delete() calls in replica_calculator.go used incomplete 2-key label maps, which would silently no-op since Prometheus requires an exact match on all declared labels. Use getPrometheusLabels(wpa) to provide the full label set. Co-authored-by: Claude Opus 4.6 <[email protected]> (cherry picked from commit 87168a7)
gh-worker-dd-devflow-36fce6
bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
sblumenthal
approved these changes
Apr 9, 2026
gh-worker-dd-mergequeue-cf854d
bot
merged commit 1ed4511
into
v0.11
40 of 50 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport 87168a7 from #321.
Human-written intent
Add
dry_runtag to all metrics to make it easier to filter by the enabled WPA when graphing various WPA metrics. The PR updates what I believe to be all the relevant places.AI-written Summary
dry_runlabel ("true"/"false") to all WPA Prometheus metrics, making it trivial to filter/group dashboards and alerts by dry-run state without needing a join on the separatedry_rungauge metric.defaultPromLabelsand to the custom label sets used bylifecycleControlStatusandlabelsInfo.Test plan
go build ./...compilesgo test ./controllers/datadoghq/passes🤖 Generated with Claude Code
AI assessment of Intent vs Implementation
Verdict: Implementation matches intent. The
dry_runlabel is added to all three label sets (defaultPromLabels,lifecycleControlStatus,labelsInfo) and populated consistently viastrconv.FormatBool(wpa.Spec.DryRun)across all metric emission and cleanup paths. Tests are updated accordingly.