Skip to content

Conversation

@git-thuerk-done
Copy link
Contributor

What does this PR do? What is the motivation?

Adds the multifiltersearch shortcode to the NDM Supported devices page to aid in searching for supported vendor profiles. Moves the top section to the bottom in a new Troubleshooting section as it felt awkward having that listed above the search table.
Moves the links to inline markdown format as that is what is supported for frontmatter links

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:

Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.

Additional notes

@git-thuerk-done git-thuerk-done requested a review from a team as a code owner December 29, 2025 22:22
@github-actions
Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

Copy link
Contributor

@brett0000FF brett0000FF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Two comments that can wait for a follow up if you agree (these impacted the original):

  • Some of the vendor names are not capitalized correctly. For example, Apc -> APC.
  • I think it would be more useful if all of the Cisco items were split into their own rows. Otherwise, it's difficult to know which file applies to which entry.

@git-thuerk-done
Copy link
Contributor Author

Looks good! Two comments that can wait for a follow up if you agree (these impacted the original):

  • Some of the vendor names are not capitalized correctly. For example, Apc -> APC.
  • I think it would be more useful if all of the Cisco items were split into their own rows. Otherwise, it's difficult to know which file applies to which entry.

those are great callouts! I think it's impt to fix the Cisco items so i'll do that with this PR

@git-thuerk-done git-thuerk-done merged commit f7acda8 into master Dec 30, 2025
16 checks passed
@git-thuerk-done git-thuerk-done deleted the aliciathuerk/add-shortcode-NDM branch December 30, 2025 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants