-
Notifications
You must be signed in to change notification settings - Fork 324
Set default codeowner file path to UNKNOWN #10502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sarahchen6
wants to merge
1
commit into
master
Choose a base branch
from
sarahchen6/fix-codeowners
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 62 metrics, 9 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.60.0-SNAPSHOT~a0db60c49b, baseline=1.60.0-SNAPSHOT~d4b0b33abb
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.064 s) : 0, 1064235
Total [baseline] (8.714 s) : 0, 8714171
Agent [candidate] (1.068 s) : 0, 1067767
Total [candidate] (8.75 s) : 0, 8750099
section iast
Agent [baseline] (1.228 s) : 0, 1228174
Total [baseline] (9.361 s) : 0, 9360511
Agent [candidate] (1.228 s) : 0, 1227811
Total [candidate] (9.354 s) : 0, 9354266
gantt
title insecure-bank - break down per module: candidate=1.60.0-SNAPSHOT~a0db60c49b, baseline=1.60.0-SNAPSHOT~d4b0b33abb
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.192 ms) : 0, 1192
crashtracking [candidate] (1.183 ms) : 0, 1183
BytebuddyAgent [baseline] (629.637 ms) : 0, 629637
BytebuddyAgent [candidate] (631.234 ms) : 0, 631234
AgentMeter [baseline] (28.559 ms) : 0, 28559
AgentMeter [candidate] (28.79 ms) : 0, 28790
GlobalTracer [baseline] (256.852 ms) : 0, 256852
GlobalTracer [candidate] (258.818 ms) : 0, 258818
AppSec [baseline] (32.795 ms) : 0, 32795
AppSec [candidate] (33.086 ms) : 0, 33086
Debugger [baseline] (61.494 ms) : 0, 61494
Debugger [candidate] (60.663 ms) : 0, 60663
Remote Config [baseline] (609.581 µs) : 0, 610
Remote Config [candidate] (623.793 µs) : 0, 624
Telemetry [baseline] (11.461 ms) : 0, 11461
Telemetry [candidate] (10.803 ms) : 0, 10803
Flare Poller [baseline] (6.229 ms) : 0, 6229
Flare Poller [candidate] (7.174 ms) : 0, 7174
section iast
crashtracking [baseline] (1.183 ms) : 0, 1183
crashtracking [candidate] (1.179 ms) : 0, 1179
BytebuddyAgent [baseline] (794.255 ms) : 0, 794255
BytebuddyAgent [candidate] (793.791 ms) : 0, 793791
AgentMeter [baseline] (11.119 ms) : 0, 11119
AgentMeter [candidate] (11.119 ms) : 0, 11119
GlobalTracer [baseline] (246.819 ms) : 0, 246819
GlobalTracer [candidate] (246.932 ms) : 0, 246932
AppSec [baseline] (33.916 ms) : 0, 33916
AppSec [candidate] (33.07 ms) : 0, 33070
Debugger [baseline] (65.731 ms) : 0, 65731
Debugger [candidate] (66.786 ms) : 0, 66786
Remote Config [baseline] (542.217 µs) : 0, 542
Remote Config [candidate] (539.754 µs) : 0, 540
Telemetry [baseline] (8.804 ms) : 0, 8804
Telemetry [candidate] (8.786 ms) : 0, 8786
Flare Poller [baseline] (3.574 ms) : 0, 3574
Flare Poller [candidate] (3.487 ms) : 0, 3487
IAST [baseline] (27.002 ms) : 0, 27002
IAST [candidate] (26.975 ms) : 0, 26975
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.60.0-SNAPSHOT~a0db60c49b, baseline=1.60.0-SNAPSHOT~d4b0b33abb
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.06 s) : 0, 1059532
Total [baseline] (10.889 s) : 0, 10888818
Agent [candidate] (1.07 s) : 0, 1069985
Total [candidate] (10.925 s) : 0, 10925399
section appsec
Agent [baseline] (1.24 s) : 0, 1239672
Total [baseline] (11.101 s) : 0, 11101093
Agent [candidate] (1.246 s) : 0, 1246377
Total [candidate] (10.965 s) : 0, 10964533
section iast
Agent [baseline] (1.23 s) : 0, 1230150
Total [baseline] (11.082 s) : 0, 11081866
Agent [candidate] (1.231 s) : 0, 1230695
Total [candidate] (11.156 s) : 0, 11156081
section profiling
Agent [baseline] (1.193 s) : 0, 1193101
Total [baseline] (10.877 s) : 0, 10877256
Agent [candidate] (1.19 s) : 0, 1190471
Total [candidate] (10.957 s) : 0, 10957207
gantt
title petclinic - break down per module: candidate=1.60.0-SNAPSHOT~a0db60c49b, baseline=1.60.0-SNAPSHOT~d4b0b33abb
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.177 ms) : 0, 1177
crashtracking [candidate] (1.188 ms) : 0, 1188
BytebuddyAgent [baseline] (626.184 ms) : 0, 626184
BytebuddyAgent [candidate] (631.666 ms) : 0, 631666
AgentMeter [baseline] (28.778 ms) : 0, 28778
AgentMeter [candidate] (28.935 ms) : 0, 28935
GlobalTracer [baseline] (256.594 ms) : 0, 256594
GlobalTracer [candidate] (258.734 ms) : 0, 258734
AppSec [baseline] (32.762 ms) : 0, 32762
AppSec [candidate] (32.874 ms) : 0, 32874
Debugger [baseline] (60.784 ms) : 0, 60784
Debugger [candidate] (61.548 ms) : 0, 61548
Remote Config [baseline] (600.83 µs) : 0, 601
Remote Config [candidate] (626.712 µs) : 0, 627
Telemetry [baseline] (13.028 ms) : 0, 13028
Telemetry [candidate] (15.239 ms) : 0, 15239
Flare Poller [baseline] (4.458 ms) : 0, 4458
Flare Poller [candidate] (3.818 ms) : 0, 3818
section appsec
crashtracking [baseline] (1.183 ms) : 0, 1183
crashtracking [candidate] (1.195 ms) : 0, 1195
BytebuddyAgent [baseline] (658.1 ms) : 0, 658100
BytebuddyAgent [candidate] (662.691 ms) : 0, 662691
AgentMeter [baseline] (11.783 ms) : 0, 11783
AgentMeter [candidate] (11.85 ms) : 0, 11850
GlobalTracer [baseline] (258.83 ms) : 0, 258830
GlobalTracer [candidate] (259.731 ms) : 0, 259731
AppSec [baseline] (168.155 ms) : 0, 168155
AppSec [candidate] (168.835 ms) : 0, 168835
Debugger [baseline] (67.455 ms) : 0, 67455
Debugger [candidate] (67.706 ms) : 0, 67706
Remote Config [baseline] (700.843 µs) : 0, 701
Remote Config [candidate] (682.184 µs) : 0, 682
Telemetry [baseline] (9.163 ms) : 0, 9163
Telemetry [candidate] (9.154 ms) : 0, 9154
Flare Poller [baseline] (3.6 ms) : 0, 3600
Flare Poller [candidate] (3.677 ms) : 0, 3677
IAST [baseline] (25.364 ms) : 0, 25364
IAST [candidate] (25.491 ms) : 0, 25491
section iast
crashtracking [baseline] (1.193 ms) : 0, 1193
crashtracking [candidate] (1.182 ms) : 0, 1182
BytebuddyAgent [baseline] (794.385 ms) : 0, 794385
BytebuddyAgent [candidate] (795.415 ms) : 0, 795415
AgentMeter [baseline] (11.121 ms) : 0, 11121
AgentMeter [candidate] (11.125 ms) : 0, 11125
GlobalTracer [baseline] (247.378 ms) : 0, 247378
GlobalTracer [candidate] (247.674 ms) : 0, 247674
AppSec [baseline] (32.158 ms) : 0, 32158
AppSec [candidate] (31.974 ms) : 0, 31974
Debugger [baseline] (68.885 ms) : 0, 68885
Debugger [candidate] (68.674 ms) : 0, 68674
Remote Config [baseline] (541.948 µs) : 0, 542
Remote Config [candidate] (538.021 µs) : 0, 538
Telemetry [baseline] (8.769 ms) : 0, 8769
Telemetry [candidate] (8.601 ms) : 0, 8601
Flare Poller [baseline] (3.482 ms) : 0, 3482
Flare Poller [candidate] (3.475 ms) : 0, 3475
IAST [baseline] (27.074 ms) : 0, 27074
IAST [candidate] (26.868 ms) : 0, 26868
section profiling
ProfilingAgent [baseline] (98.961 ms) : 0, 98961
ProfilingAgent [candidate] (99.754 ms) : 0, 99754
crashtracking [baseline] (1.203 ms) : 0, 1203
crashtracking [candidate] (1.238 ms) : 0, 1238
BytebuddyAgent [baseline] (684.519 ms) : 0, 684519
BytebuddyAgent [candidate] (681.714 ms) : 0, 681714
AgentMeter [baseline] (8.698 ms) : 0, 8698
AgentMeter [candidate] (8.655 ms) : 0, 8655
GlobalTracer [baseline] (216.73 ms) : 0, 216730
GlobalTracer [candidate] (216.162 ms) : 0, 216162
AppSec [baseline] (32.494 ms) : 0, 32494
AppSec [candidate] (32.544 ms) : 0, 32544
Debugger [baseline] (67.591 ms) : 0, 67591
Debugger [candidate] (67.382 ms) : 0, 67382
Remote Config [baseline] (596.046 µs) : 0, 596
Remote Config [candidate] (604.17 µs) : 0, 604
Telemetry [baseline] (8.853 ms) : 0, 8853
Telemetry [candidate] (8.872 ms) : 0, 8872
Flare Poller [baseline] (3.704 ms) : 0, 3704
Flare Poller [candidate] (3.797 ms) : 0, 3797
Profiling [baseline] (99.525 ms) : 0, 99525
Profiling [candidate] (100.323 ms) : 0, 100323
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 1 performance regressions! Performance is the same for 16 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~a0db60c49b, baseline=1.60.0-SNAPSHOT~d4b0b33abb
dateFormat X
axisFormat %s
section baseline
no_agent (1.179 ms) : 1167, 1190
. : milestone, 1179,
iast (3.067 ms) : 3031, 3104
. : milestone, 3067,
iast_FULL (6.101 ms) : 6038, 6164
. : milestone, 6101,
iast_GLOBAL (3.521 ms) : 3464, 3577
. : milestone, 3521,
profiling (2.021 ms) : 2004, 2039
. : milestone, 2021,
tracing (1.844 ms) : 1828, 1860
. : milestone, 1844,
section candidate
no_agent (1.172 ms) : 1161, 1183
. : milestone, 1172,
iast (3.146 ms) : 3104, 3188
. : milestone, 3146,
iast_FULL (5.932 ms) : 5872, 5992
. : milestone, 5932,
iast_GLOBAL (3.529 ms) : 3477, 3580
. : milestone, 3529,
profiling (2.29 ms) : 2269, 2310
. : milestone, 2290,
tracing (1.82 ms) : 1804, 1836
. : milestone, 1820,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~a0db60c49b, baseline=1.60.0-SNAPSHOT~d4b0b33abb
dateFormat X
axisFormat %s
section baseline
no_agent (18.184 ms) : 18000, 18368
. : milestone, 18184,
appsec (18.587 ms) : 18400, 18773
. : milestone, 18587,
code_origins (17.369 ms) : 17199, 17539
. : milestone, 17369,
iast (17.73 ms) : 17556, 17905
. : milestone, 17730,
profiling (20.718 ms) : 20507, 20929
. : milestone, 20718,
tracing (18.48 ms) : 18297, 18664
. : milestone, 18480,
section candidate
no_agent (19.306 ms) : 19104, 19508
. : milestone, 19306,
appsec (18.665 ms) : 18474, 18856
. : milestone, 18665,
code_origins (17.854 ms) : 17675, 18032
. : milestone, 17854,
iast (17.72 ms) : 17543, 17897
. : milestone, 17720,
profiling (18.714 ms) : 18525, 18902
. : milestone, 18714,
tracing (17.704 ms) : 17532, 17877
. : milestone, 17704,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~a0db60c49b, baseline=1.60.0-SNAPSHOT~d4b0b33abb
dateFormat X
axisFormat %s
section baseline
no_agent (15.025 s) : 15025000, 15025000
. : milestone, 15025000,
appsec (15.103 s) : 15103000, 15103000
. : milestone, 15103000,
iast (18.303 s) : 18303000, 18303000
. : milestone, 18303000,
iast_GLOBAL (17.814 s) : 17814000, 17814000
. : milestone, 17814000,
profiling (14.592 s) : 14592000, 14592000
. : milestone, 14592000,
tracing (14.653 s) : 14653000, 14653000
. : milestone, 14653000,
section candidate
no_agent (15.069 s) : 15069000, 15069000
. : milestone, 15069000,
appsec (14.709 s) : 14709000, 14709000
. : milestone, 14709000,
iast (17.735 s) : 17735000, 17735000
. : milestone, 17735000,
iast_GLOBAL (17.8 s) : 17800000, 17800000
. : milestone, 17800000,
profiling (14.982 s) : 14982000, 14982000
. : milestone, 14982000,
tracing (14.605 s) : 14605000, 14605000
. : milestone, 14605000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~a0db60c49b, baseline=1.60.0-SNAPSHOT~d4b0b33abb
dateFormat X
axisFormat %s
section baseline
no_agent (1.478 ms) : 1467, 1490
. : milestone, 1478,
appsec (3.794 ms) : 3572, 4016
. : milestone, 3794,
iast (2.265 ms) : 2195, 2334
. : milestone, 2265,
iast_GLOBAL (2.321 ms) : 2250, 2392
. : milestone, 2321,
profiling (2.093 ms) : 2037, 2148
. : milestone, 2093,
tracing (2.078 ms) : 2024, 2133
. : milestone, 2078,
section candidate
no_agent (1.491 ms) : 1479, 1502
. : milestone, 1491,
appsec (3.798 ms) : 3574, 4022
. : milestone, 3798,
iast (2.279 ms) : 2209, 2350
. : milestone, 2279,
iast_GLOBAL (2.318 ms) : 2248, 2389
. : milestone, 2318,
profiling (2.133 ms) : 2075, 2191
. : milestone, 2133,
tracing (2.081 ms) : 2027, 2136
. : milestone, 2081,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp: tooling
Build & Tooling
tag: no release notes
Changes to exclude from release notes
type: enhancement
Enhancements and improvements
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
If the codeowner file is not found, set as
UNKNOWN.Motivation
Previously, an unknown codeowner file would be set as
"/", which would not pattern-match to the default codeowner setting of*. See this link for tests without codeowners formaster, and this link for tests without codeowners for this branch.Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]